-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sticky: Please read first] Broken website / login ! Now what ? #83
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I’ve minimised previous comments as they were about general usability of the add-on. Please open a new issue (or comment on one that already exists and is on that topic) for such problems. In this issue, users can report which websites/parameters for review to be included in the whitelist. Please report, for every proposed entry:
I’ll try to get around to each suggestion and test it and see if it should be included. For example for this report from a different bug:
|
Originally posted by @Rtizer-9 in #106 (comment) No worries @Rtizer-9 I do check every suggestion before including it. I think it makes sense to be rather lenient on the login rules though. The only reason I decided not to go for whitelisting all parameters (i.e. |
|
I think the facebook links should be fixed from the new release. I didn’t have time to give those examples specifically though, but the new version is a fix for |
I was trying to solve above instagram breakage using different regex and got success in few cases but the .+ or other were not working for every case. In the end while I accidentally hovered over ?, it was written that to match all the paths leave it empty and it worked really. Thought I should let you know. |
|
CL breaks page functionality here: The entries in log are |
Hey @Cimbali , hope you're safe and doing well. I just found out a bug in facebook rules. The whole scenario is like this: If you visit a url of pattern: https://www.facebook.com/photo.php?fbid=xxxxxxxxxxxxxxx&set=a.xxxxxxxxxxxxxxx&type=3 , the fbid parameter gets stripped out because of rules but when I looked at ClearUrls' rules, I saw that there are some exceptions and "photo" is one of them. So maybe when you imported the rules from there, the exceptions were not taken care of. I mean that's the only conclusion one care draw given how CL is playing with those links. The fbid parameters gets stripped out and after visiting the link you get that "page isn't available" error giving the user an illusion that the post is indeed private. Please also have a look at other such rules which needs to have exceptions. |
I am reading the wiki, and I didn't see the information I was looking for to allow a generally well-behaved website to do complex internal links, but not external. Do I put the domain in the parameters of what is allowed, or...? |
In general it’s the target of the link you’re whitelisting. Unless you’re looking at javascript link, in which case there’s no way of knowing in advance what the target is before executing the javascript and its potential tracking actions -- in that case you have to whitelist the origin domain. So for a website on
I hope that somewhat answers your question? From what I understand of your problem, if you trust that website, whitelist its redirects (i.e. matching |
Is there a website that is not working anymore? Maybe reloading infinitely? Here’s what you can do:
1. Whitelist the URL
You’re done ! In very few cases there might be multiple requests redirecting to the same page.
2. Consider contributing the cleaning/whitelisting rule
Do you think the website is used by many people, or could be useful to the wider community as a default rule? Please open an issue or post it here as a comment and I’ll try to integrate it. What I ned to know is:
You can search for the rule by filtering by website in CleanLink’s configuration page, or in the rules file that you can export from that page.
The text was updated successfully, but these errors were encountered: