Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Allow to set the default branch on circle orb init #8

Open
at-ishikawa opened this issue Oct 9, 2020 · 6 comments
Open

Allow to set the default branch on circle orb init #8

at-ishikawa opened this issue Oct 9, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@at-ishikawa
Copy link

Orb version:

What happened:

The job orb-tools/dev-promote-prod-from-commit-subject on integration-test_deploy workflow on Circle CI configuration doesn't work for the new repository, because since October 1, GitHub allows developers to set default branch, and the default value of it is main, not master.

Expected behavior:

circleci orb init allows us to set the default branch.

Additional Information:

@at-ishikawa at-ishikawa added the bug Something isn't working label Oct 9, 2020
@FelicianoTech
Copy link

@CircleCI-Public/cpeng

@gmemstr
Copy link
Contributor

gmemstr commented Oct 13, 2020

orb init assumes your repository is completely empty, without any branches or content, and initialises both the master and alpha branches. I think being able to specify an alternatively default branch would be nice during this process, but I don't see it high on the priority list myself.

@nbialostosky
Copy link
Contributor

@gmemstr Now that GitHub is defaulting all new repositories to main instead of master do we think this issue has a higher priority now? https://github.blog/changelog/2020-10-01-the-default-branch-for-newly-created-repositories-is-now-main/

Or at the very least can we make any updates to handle both master and main?

@gmemstr
Copy link
Contributor

gmemstr commented Jan 15, 2021

@nbialostosky We do account for it in this template now, but I'll get the ball rolling on choosing during the setup process soon - still unsure about switching the default but there's a good chance it could happen :)

@netcazean
Copy link

#29

@netcazean
Copy link

#9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants