Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Bug: add_ssh_keys not accepted when doing an import #283

Open
2 of 4 tasks
mathaeus opened this issue Sep 8, 2022 · 3 comments
Open
2 of 4 tasks

Bug: add_ssh_keys not accepted when doing an import #283

mathaeus opened this issue Sep 8, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@mathaeus
Copy link

mathaeus commented Sep 8, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

The regular add_ssh_keys is not accepted by the VCE.

Screenshot 2022-09-08 at 16 27 56

Minimum reproduction code

https://gist.github.com/mathaeus/972c9e4ee827077b1a24d64a0e043978

Steps to reproduce

Import config with add_ssh_keys

Expected behavior

The import of existing valid circleCI config files should just work.

Workaround

Changing

add_ssh_keys

to

add_ssh_keys: {}

fixes the problem.

BUT, such things are quite annoying when one once to get started with the VCE. Especially if one triple checked that the current manually written config is valid via

> circleci config validate
Config file at .circleci/config.yml is valid.

CircleCI Config SDK version

Whatever the online editor gave me:

# This configuration has been automatically generated by the CircleCI Config SDK.
# For more information, see https://github.com/CircleCI-Public/circleci-config-sdk-ts
# SDK Version: 0.9.0-alpha.16
# VCE Version: v0.10.5
# Modeled with the CircleCI visual config editor.
# For more information, see https://github.com/CircleCI-Public/visual-config-editor

Node.js version

No response

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@mathaeus mathaeus added the bug Something isn't working label Sep 8, 2022
@mathaeus mathaeus changed the title Bug: add_ssh_keys not accepted Bug: add_ssh_keys not accepted when doing an import Sep 8, 2022
@Jaryt
Copy link
Contributor

Jaryt commented Sep 20, 2022

This is actually a Config SDK Parser issue, and I've closed this in CircleCI-Public/circleci-config-parser-ts#14 (Project is currently internal, will get that updated)
Thanks for raising!

@Jaryt Jaryt closed this as completed Sep 20, 2022
@mathaeus
Copy link
Author

Thanks @Jaryt 👍

@Jaryt Jaryt reopened this Sep 20, 2022
@Jaryt
Copy link
Contributor

Jaryt commented Sep 20, 2022

Thanks @Jaryt 👍

No problem! I'll actually reopen this until we have the updated version of the parser in the VCE.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants