diff --git a/analysis_options.yaml b/analysis_options.yaml index 8acc3356..718e36d6 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -8,8 +8,6 @@ linter: # Util classes avoid_classes_with_only_static_members: false - avoid_redundant_argument_values: false - non_constant_identifier_names: false constant_identifier_names: false diff --git a/lib/services/database_service.dart b/lib/services/database_service.dart index 65f47f05..c644de5e 100644 --- a/lib/services/database_service.dart +++ b/lib/services/database_service.dart @@ -1,5 +1,4 @@ import 'package:flutter/foundation.dart'; -import 'package:hive/hive.dart'; import 'package:hive_flutter/hive_flutter.dart'; import 'package:mobile_app/models/ib/ib_raw_page_data.dart'; diff --git a/lib/ui/components/cv_password_field.dart b/lib/ui/components/cv_password_field.dart index 38184f97..79f515b7 100644 --- a/lib/ui/components/cv_password_field.dart +++ b/lib/ui/components/cv_password_field.dart @@ -1,5 +1,4 @@ import 'package:flutter/material.dart'; -import 'package:flutter/services.dart'; import 'package:mobile_app/cv_theme.dart'; class CVPasswordField extends StatefulWidget { diff --git a/lib/ui/views/groups/add_assignment_view.dart b/lib/ui/views/groups/add_assignment_view.dart index 4238e3a3..4c7cc6c8 100644 --- a/lib/ui/views/groups/add_assignment_view.dart +++ b/lib/ui/views/groups/add_assignment_view.dart @@ -146,7 +146,7 @@ class _AddAssignmentViewState extends State { value: _restrictions.contains(name), onChanged: (value) { if (value) { - _restrictions.add((name)); + _restrictions.add(name); } else { _restrictions.remove(name); } diff --git a/lib/ui/views/groups/assignment_details_view.dart b/lib/ui/views/groups/assignment_details_view.dart index b03d4789..997d8991 100644 --- a/lib/ui/views/groups/assignment_details_view.dart +++ b/lib/ui/views/groups/assignment_details_view.dart @@ -2,7 +2,6 @@ import 'dart:convert'; import 'package:flutter/material.dart'; import 'package:flutter_html/flutter_html.dart'; -import 'package:flutter_html/style.dart'; import 'package:get/get.dart'; import 'package:intl/intl.dart'; import 'package:mobile_app/cv_theme.dart'; diff --git a/lib/ui/views/groups/update_assignment_view.dart b/lib/ui/views/groups/update_assignment_view.dart index 9b717a23..828b9117 100644 --- a/lib/ui/views/groups/update_assignment_view.dart +++ b/lib/ui/views/groups/update_assignment_view.dart @@ -126,7 +126,7 @@ class _UpdateAssignmentViewState extends State { value: _restrictions.contains(name), onChanged: (value) { if (value) { - _restrictions.add((name)); + _restrictions.add(name); } else { _restrictions.remove(name); } diff --git a/lib/ui/views/ib/builders/ib_webview_builder.dart b/lib/ui/views/ib/builders/ib_webview_builder.dart index 1e077cee..5bd7f79d 100644 --- a/lib/ui/views/ib/builders/ib_webview_builder.dart +++ b/lib/ui/views/ib/builders/ib_webview_builder.dart @@ -1,6 +1,5 @@ import 'package:flutter/material.dart'; import 'package:flutter_html/flutter_html.dart'; -import 'package:flutter_html/html_parser.dart'; import 'package:flutter_markdown/flutter_markdown.dart'; import 'package:webview_flutter/webview_flutter.dart'; import 'package:markdown/markdown.dart' as md; diff --git a/lib/ui/views/projects/project_details_view.dart b/lib/ui/views/projects/project_details_view.dart index 422c0fb6..97b51bcb 100644 --- a/lib/ui/views/projects/project_details_view.dart +++ b/lib/ui/views/projects/project_details_view.dart @@ -1,7 +1,6 @@ import 'package:flutter/gestures.dart'; import 'package:flutter/material.dart'; import 'package:flutter_html/flutter_html.dart'; -import 'package:flutter_html/style.dart'; import 'package:get/get.dart'; import 'package:mobile_app/cv_theme.dart'; import 'package:mobile_app/config/environment_config.dart'; diff --git a/lib/utils/router.dart b/lib/utils/router.dart index 6086b9b1..d036ebbe 100644 --- a/lib/utils/router.dart +++ b/lib/utils/router.dart @@ -1,4 +1,3 @@ -import 'package:flutter/cupertino.dart'; import 'package:flutter/material.dart'; import 'package:mobile_app/models/assignments.dart'; import 'package:mobile_app/models/groups.dart'; diff --git a/test/service_tests/assignments_api_test.dart b/test/service_tests/assignments_api_test.dart index 58893c5e..2c85732e 100644 --- a/test/service_tests/assignments_api_test.dart +++ b/test/service_tests/assignments_api_test.dart @@ -189,7 +189,7 @@ void main() { (_) => Future.value(Response('{"message": "reopened"}', 200))); var _assignmentsApi = HttpAssignmentsApi(); - expect((await _assignmentsApi.reopenAssignment('1')), 'reopened'); + expect(await _assignmentsApi.reopenAssignment('1'), 'reopened'); }); test('When called & http client throws Exceptions', () async { @@ -219,7 +219,7 @@ void main() { Future.value(Response('{"message": "project created"}', 200))); var _assignmentsApi = HttpAssignmentsApi(); - expect((await _assignmentsApi.startAssignment('1')), 'project created'); + expect(await _assignmentsApi.startAssignment('1'), 'project created'); }); test('When called & http client throws Exceptions', () async { diff --git a/test/service_tests/users_api_test.dart b/test/service_tests/users_api_test.dart index fb67f810..af4bee93 100644 --- a/test/service_tests/users_api_test.dart +++ b/test/service_tests/users_api_test.dart @@ -213,7 +213,7 @@ void main() { ApiUtils.client = MockClient((_) => Future.value(Response('{"message": "instructions sent"}', 200))); - expect((await _usersApi.sendResetPasswordInstructions('test@test.com')), + expect(await _usersApi.sendResetPasswordInstructions('test@test.com'), true); }); diff --git a/test/ui_tests/groups/update_assignment_view_test.dart b/test/ui_tests/groups/update_assignment_view_test.dart index 0572b668..3cd7ed7f 100644 --- a/test/ui_tests/groups/update_assignment_view_test.dart +++ b/test/ui_tests/groups/update_assignment_view_test.dart @@ -1,5 +1,4 @@ import 'package:datetime_picker_formfield/datetime_picker_formfield.dart'; -import 'package:flutter/cupertino.dart'; import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; import 'package:get/get.dart';