Adding modules for IGMP interface policy object. (DCNE-128) #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvitha-jain
requested review from
akinross,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
anvitha-jain
force-pushed
the
igmp_interface
branch
from
4d246b8 to
fb7a54f
Compare
github-actions
bot
changed the title
anvitha-jain
changed the title
anvitha-jain
force-pushed
the
igmp_interface
branch
3 times, most recently
from
eeb7c0f to
81f2537
Compare
samiib
requested changes
Jan 20, 2025
samiib
reviewed
Jan 20, 2025
anvitha-jain
force-pushed
the
igmp_interface
branch
from
81f2537 to
5fc8984
Compare
anvitha-jain
force-pushed
the
igmp_interface
branch
from
5fc8984 to
a038ff4
Compare
samiib
requested changes
Jan 23, 2025
…ve and changed update task to support the changes.
anvitha-jain
force-pushed
the
igmp_interface
branch
from
a038ff4 to
26f07e9
Compare
shrsr
requested changes
Jan 24, 2025
tests/integration/targets/ndo_tenant_igmp_interface_policy/tasks/main.yml
Outdated
Show resolved
Hide resolved
anvitha-jain
force-pushed
the
igmp_interface
branch
from
26f07e9 to
b6b2ae6
Compare
lhercot
requested changes
Jan 24, 2025
| - Defaults to C(disabled) when unset during creation. | ||
| type: str | ||
| choices: [ enabled, disabled ] | ||
| aliases: [ allow_version3_asm ] |
| - The maximum multicast entries value. | ||
| - Defaults to C(4294967295) when unset during creation. | ||
| - The valid range is from C(1) to C(4294967295). | ||
| - This parameter is only applicable when the O(state_limit_route_map_uuid) is not empty. |
There was a problem hiding this comment.
or state_limit_route_map right?
| notes: | ||
| - The O(template) must exist before using this module in your playbook. | ||
| Use M(cisco.mso.ndo_template) to create the Tenant template. | ||
| - The O(state_limit_route_map_uuid), O(report_policy_route_map_uuid), O(static_report_route_map_uuid) must exist before using this module in your playbook. |
There was a problem hiding this comment.
Rephrase that the route map object need to exist but not the uuid and that is also for the name.
shrsr
requested changes
Jan 24, 2025
| Use M(cisco.mso.ndo_tenant_route_map_policy_for_multicast) to create the Route Map Policy for Multicast. | ||
| seealso: | ||
| - module: cisco.mso.ndo_template | ||
| - module: cisco.mso.ndo_tenant_route_map_policy_for_multicast |
There was a problem hiding this comment.
ndo_tenant_route_map_policy_for_multicast is the wrong name. It think it's ndo_route_map_policy_multicast
There was a problem hiding this comment.
I would actually remove this
| - The O(template) must exist before using this module in your playbook. | ||
| Use M(cisco.mso.ndo_template) to create the Tenant template. | ||
| - The O(state_limit_route_map_uuid), O(report_policy_route_map_uuid), O(static_report_route_map_uuid) must exist before using this module in your playbook. | ||
| Use M(cisco.mso.ndo_tenant_route_map_policy_for_multicast) to create the Route Map Policy for Multicast. |
There was a problem hiding this comment.
I think it should be M(cisco.mso.ndo_route_map_policy_multicast).
Please confirm..
There was a problem hiding this comment.
I would actually remove this
| notes: | ||
| - The O(template) must exist before using this module in your playbook. | ||
| Use M(cisco.mso.ndo_template) to create the Tenant template. | ||
| - The O(state_limit_route_map_uuid), O(report_policy_route_map_uuid), O(static_report_route_map_uuid) must exist before using this module in your playbook. |
There was a problem hiding this comment.
I don't think this note is accurate. I would rephrase it or actually remove it..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.