Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to query the object using UUID (DCNE-184) #594

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sajagana
Copy link
Collaborator

@sajagana sajagana commented Jan 9, 2025

No description provided.

@sajagana sajagana linked an issue Jan 9, 2025 that may be closed by this pull request
@sajagana sajagana force-pushed the 537_query_using_uuid branch from 8c6e1a9 to 7c57f5c Compare January 9, 2025 10:23
@github-actions github-actions bot changed the title Added support to query the object using UUID Added support to query the object using UUID (DCNE-184) Jan 9, 2025
@sajagana sajagana force-pushed the 537_query_using_uuid branch from 7c57f5c to e3d3e5e Compare January 9, 2025 10:27
gmicol
gmicol previously approved these changes Jan 9, 2025
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain previously approved these changes Jan 9, 2025
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/modules/ndo_dhcp_option_policy.py Outdated Show resolved Hide resolved
@sajagana sajagana dismissed stale reviews from anvitha-jain and gmicol via 54af310 January 10, 2025 05:27
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update query on uuid, on all the existing NDO modules (DCNE-184)
6 participants