Replaced the ndo modules current value with actual API response value (DCNE-185) #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajagana
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
samiib and
shrsr
as code owners
… response value and fixed the output value of the ndo_route_map_policy_multicast and ndo_vlan_pool modules
sajagana
force-pushed
the
538_ndo_modules_current_value_fix
branch
from
8c27fc9 to
39d30ea
Compare
github-actions
bot
changed the title
akinross
requested changes
Dec 20, 2024
| @@ -85,20 +83,20 @@ | |||
| - cm_create_new_l3_domain is changed | |||
| - cm_create_new_l3_domain.previous == {} | |||
| - cm_create_new_l3_domain.current.name == "ansible_test_l3_domain" | |||
| - cm_create_new_l3_domain.current.pool == "ansible_test_vlan_pool_1" | |||
| - cm_create_new_l3_domain.current.pool != "" | |||
There was a problem hiding this comment.
so we only return the pool uuid?
There was a problem hiding this comment.
Yes, let me insert the name attribute into the output.
There was a problem hiding this comment.
But how do we compare this to the input of name? or should we expose both uuid and pool name? in output do we only want to have uuid returned, as this from normal input is not something a user knows unless the use a query on the vlan pool object or create the vlan pool via ansible and refer to the returned output.
…current portion of the ndo_l3_domain module
sajagana
force-pushed
the
538_ndo_modules_current_value_fix
branch
from
2240b6b to
5943cf6
Compare
anvitha-jain
approved these changes
Jan 9, 2025
akinross
requested changes
Jan 13, 2025
| @@ -186,15 +179,14 @@ def main(): | |||
|
|
|||
| if pool and match.details.get("pool") != pool: | |||
| ops.append(dict(op="replace", path="{0}/{1}/pool".format(path, match.index), value=mso_template.get_vlan_pool_uuid(pool))) | |||
| match.details["pool"] = pool | |||
| match.details["pool"] = mso_template.get_vlan_pool_uuid(pool) | |||
There was a problem hiding this comment.
think same issue is happening for physical domain
akinross
requested changes
Jan 13, 2025
| response = mso.request(mso_template.templates_path, method="POST", data=payload) | ||
| payload["templateId"] = response.get("templateId") | ||
| mso.existing = mso.request(mso_template.templates_path, method="POST", data=payload) | ||
| payload["templateId"] = mso.existing.get("templateId") |
There was a problem hiding this comment.
can you check the response for tenant and its corresponding id in the response also?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Fixed the below NDO modules: