Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.6-beta breaks custom_attributes in the "endpoint" resource #108

Open
rfc1149 opened this issue Oct 23, 2023 · 7 comments
Open

0.6.6-beta breaks custom_attributes in the "endpoint" resource #108

rfc1149 opened this issue Oct 23, 2023 · 7 comments

Comments

@rfc1149
Copy link

rfc1149 commented Oct 23, 2023

Upon upgrading my provider version to v0.6.6-beta or later, I'm receiving an error that looks like this:

   resource "ciscoise_endpoint" "test_laptop" {
parameters.0.custom_attributes.0.custom_attributes: '' expected type
'string', got unconvertible type
'isegosdk.ResponseEndpointGetEndpointByNameERSEndPointCustomAttributesCustomAttributes',
value: 'map[Owner:]'

my terraform code works just fine on v0.6.5-beta or earlier, it's a very straightforward resource definition:

resource "ciscoise_endpoint" "test_laptop" {

  parameters {
    description             = "Set with TF"
    group_id                = "<group_id>"
    mac                     = "<mac>"
    name                    = "test_laptop"
    static_group_assignment = "true"
  }
}

I believe that the root cause here is that 0.6.6-beta changed this line to be a TypeString instead of a map:

Type: schema.TypeString, //TEST,

Indeed, if we look at the data source for this same thing, we see that it's listed as a TypeMap:

We can see that it was changed in the 0.6.6-beta commit based on the git blame, and it shows here:
48388aa#diff-6b7a14e67c9c08afade28f67ddd6a9c6efe8dac58b19e70ba61e2f326010129f

Could we get this reverted back to a map?

@fmunozmiranda
Copy link
Collaborator

Hi @rfc1149 could you please retry it with last version of ISE provider and update us if bug still there?

@fmunozmiranda
Copy link
Collaborator

If we don´t get answer, this issue will be closed in next 24 hours.

@rfc1149
Copy link
Author

rfc1149 commented Jul 29, 2024

Hi sorry I am on holiday and hadn't been checking this issue super closely since it has been so long since I opened it. I will give it a try next week!

@fmunozmiranda
Copy link
Collaborator

Thank you for your answer, we will wait your tests.

@rfc1149
Copy link
Author

rfc1149 commented Aug 6, 2024

I'm still seeing the same issue on v0.8.1-beta

@fmunozmiranda
Copy link
Collaborator

@rfc1149 could you please pass us debug of provider?

@rfc1149
Copy link
Author

rfc1149 commented Sep 4, 2024

Unfortunately that's a bit tricky in my environment, is the information in the original post insufficient for a reproduction of the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants