Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-10 tests for stable branches? #279

Open
nickdesaulniers opened this issue Jan 13, 2022 · 3 comments
Open

clang-10 tests for stable branches? #279

nickdesaulniers opened this issue Jan 13, 2022 · 3 comments

Comments

@nickdesaulniers
Copy link
Member

#278 spun down our remaining clang-10 tests. I'm curious if it's worthwhile to keep some arm64 + x86_64 builds going for branches of stable with clang-10? We can probably look and see what clang versions various Android releases are using.

@nathanchance
Copy link
Member

I was thinking more about this within the context of #278 and I am not sure there is much value in continuing to build with clang-10.

  • We don't have any avenue to fix bugs in the compiler because it is not supported anymore (one of the main reasons we bumped to clang-11 on mainline).
  • If something breaks in stable for one reason or another, inserting workarounds into the source is not going to be easy without them being upstream (the stable hates taking patches just for stable).

@nickdesaulniers
Copy link
Member Author

Right, but clang-10 was supported when those branches of stable were created, and Android is still using clang-10 based versions of AOSP Clang. Having some heads up when stable takes a patch that might break these older LTS branches that have yet to go out of support might be worthwhile. We'll find such cases either way in Android though.

@nathanchance
Copy link
Member

Fair enough, I thought that the most recent version of Android had kernels compiled with clang-12 but I guess there could be other targets or older branches that matter? What branches should we support here with clang-10 and what kind of build targets are interesting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants