Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default diagnostic: T_sfc instead of canopy temperature in default diagnostics #1003

Open
AlexisRenchon opened this issue Jan 31, 2025 · 0 comments · May be fixed by #1013
Open

Default diagnostic: T_sfc instead of canopy temperature in default diagnostics #1003

AlexisRenchon opened this issue Jan 31, 2025 · 0 comments · May be fixed by #1013
Assignees

Comments

@AlexisRenchon
Copy link
Member

AlexisRenchon commented Jan 31, 2025

T_sfc is defined everywhere whereas t_canopy is set to NaN if there is no canopy

Note, this is stored in p.T_sfc and currently not in define_diagnostics.jl for the land model (but it is for the bucket).

for the bucket:

    # Bucket Surface temperature
    add_diagnostic_variable!(
        short_name = "tsfc",
        long_name = "Bucket Surface Temperature",
        standard_name = "surface_temperature",
        units = "K",
        comments = "Temperature of the bucket-land surface.",
        compute! = (out, Y, p, t) ->
            compute_surface_temperature!(out, Y, p, t, land_model),
    )

Question: Do we need a separate short_name for the land model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant