-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should this package be an Oceananigans module? #34
Comments
I don't see what's the difference of the third option from the first. |
The first option would add other orthogonal spherical shell grid options --- for example rotated lat lon grids --- to Oceananigans. Then we wouldn't need to invoke this package to test |
I like the rotated lat-lon grid option in Oceananigans. It's simple enough but very useful for things like arctic simulations |
we can also implement a test utility that builds an |
Yeah, it's not very well thought out I think. The problem I think is basically that Oceananigans doesn't have much built-in functionality for orthogonal grids. So it helps to use this package to build a tripolar grid and test some of the functionality.
Probably, either Oceananigans needs to have more built-in non-trivial grids (thereby motivating the implementation of
OrthogonalSphericalShellGrid
in Oceananigans the first place). Or, all of the orthogonal grid functionality could be moved here. A third option is to incorporate this package into Oceananigans.My hunch is that it is important to have a general orthogonal grid implementation in Oceananigans because otherwise the general implementation of operators etc is not well-motivated.
This problem has been present from the beginning with
OrthogonalSphericalShellGrid
as I recall, it wasn't even possible to use it in stand-alone simulations at first.Originally posted by @glwagner in #33 (comment)
The text was updated successfully, but these errors were encountered: