Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this package be an Oceananigans module? #34

Open
navidcy opened this issue Sep 21, 2024 · 4 comments
Open

Should this package be an Oceananigans module? #34

navidcy opened this issue Sep 21, 2024 · 4 comments

Comments

@navidcy
Copy link
Collaborator

navidcy commented Sep 21, 2024

But why OrthogonalSphericalShellGrids is a deps of the Oceananigans test suite? Perhaps that test belongs in this package?

Yeah, it's not very well thought out I think. The problem I think is basically that Oceananigans doesn't have much built-in functionality for orthogonal grids. So it helps to use this package to build a tripolar grid and test some of the functionality.

Probably, either Oceananigans needs to have more built-in non-trivial grids (thereby motivating the implementation of OrthogonalSphericalShellGrid in Oceananigans the first place). Or, all of the orthogonal grid functionality could be moved here. A third option is to incorporate this package into Oceananigans.

My hunch is that it is important to have a general orthogonal grid implementation in Oceananigans because otherwise the general implementation of operators etc is not well-motivated.

This problem has been present from the beginning with OrthogonalSphericalShellGrid as I recall, it wasn't even possible to use it in stand-alone simulations at first.

Originally posted by @glwagner in #33 (comment)

@navidcy
Copy link
Collaborator Author

navidcy commented Sep 22, 2024

Probably, either Oceananigans needs to have more built-in non-trivial grids (thereby motivating the implementation of OrthogonalSphericalShellGrid in Oceananigans the first place). Or, all of the orthogonal grid functionality could be moved here. A third option is to incorporate this package into Oceananigans.

I don't see what's the difference of the third option from the first.

@glwagner
Copy link
Member

The first option would add other orthogonal spherical shell grid options --- for example rotated lat lon grids --- to Oceananigans. Then we wouldn't need to invoke this package to test OrthogonalSphericalShellGrid because we could use the native options instead, and this package could stand alone as implementation of the more complicated versions.

@simone-silvestri
Copy link
Collaborator

I like the rotated lat-lon grid option in Oceananigans. It's simple enough but very useful for things like arctic simulations

@glwagner
Copy link
Member

we can also implement a test utility that builds an OrthogonalSphericalShellGrid from a lat-lon grid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants