Allow multiple materialized views to write to same target (#280) #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
issue #280 |
the4thamigo-uk
force-pushed
the
multiple-materialized-views_to_same_target
branch
from
e4e9b6d
to
f932efb
Compare
|
Thank you for your contribution! looking forward to reviewing this |
the4thamigo-uk
force-pushed
the
multiple-materialized-views_to_same_target
branch
from
f932efb
to
798aca9
Compare
the4thamigo-uk
added a commit
to the4thamigo-uk/dbt-clickhouse
that referenced
this pull request
Nov 13, 2024
the4thamigo-uk
added a commit
to the4thamigo-uk/dbt-clickhouse
that referenced
this pull request
Nov 13, 2024
the4thamigo-uk
force-pushed
the
multiple-materialized-views_to_same_target
branch
from
3485793
to
e661bfa
Compare
the4thamigo-uk
added a commit
to the4thamigo-uk/dbt-clickhouse
that referenced
this pull request
Nov 13, 2024
the4thamigo-uk
force-pushed
the
multiple-materialized-views_to_same_target
branch
from
e661bfa
to
277fa45
Compare
the4thamigo-uk
force-pushed
the
multiple-materialized-views_to_same_target
branch
from
277fa45
to
064ed53
Compare
|
@BentsiLeviav Ok, Ive done this. |
| "hackers.sql": MV_MODEL, | ||
| } | ||
|
|
||
| def test_create(self, project): |
There was a problem hiding this comment.
Could you also test for updates and full refresh?
There was a problem hiding this comment.
Yeah I think if you change the model to add or rename MVs, then old ones will be left running, which is incorrect.
|
Thanks @the4thamigo-uk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proposed mechanism to support having multiple materialized views pointing to the same target table.
In brief, we add tags to mark blocks of the sql which will form each of the materialized views to be created.
i.e. https://github.com/ClickHouse/dbt-clickhouse/pull/364/files#diff-b1cddf2e5c9b3d08ea2276e5cef4944b06b9744a4076c5970ff5a5edb0140f08R62.
The entire union of all such blocks is used to backfill the target table.
Checklist
Delete items not relevant to your PR: