Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Color problem #1214

Open
Djelle opened this issue Feb 7, 2025 · 3 comments
Open

Text Color problem #1214

Djelle opened this issue Feb 7, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@Djelle
Copy link

Djelle commented Feb 7, 2025

I am not 100% sure this is a bug of Bubble-card or HA.

Describe the bug
When adding a new bubble-card of the type "Horizontal Button Stack" there is a button for "+ New button". This button uses the color --primary-text-color on top of --accent-color. The correct text color to use is --text-accent-color.

The problem can be seen in the below image. Which show the button with my theme "MilCom Army".
Screenshot: https://www.djelle.dk/temp/bubble-card-color-error.jpg
I found the same problem with a default HA button, which I could fix by setting --text-accent-color.
(My uploaded theme is not updated with --text-accent-color yet.)

I use all the latest versions of HA and your mod.

Cheers
/Djelle

@Djelle Djelle added the bug Something isn't working label Feb 7, 2025
@Djelle
Copy link
Author

Djelle commented Feb 7, 2025

Also happens in the "Sub-button editor"
... and many more places wherever this color combo is used.

@Clooos
Copy link
Owner

Clooos commented Feb 12, 2025

Hi and hank you for the feedback! I already worked a bit on the contrast issues in the editor these past few days, I will do my best to not forget about these too!

Clooos added a commit that referenced this issue Feb 13, 2025
- [x] Added js-yaml as dependency
- [x] Editor styling improvements #1214
- [x] Link to share modules on GitHub in the editor 
- [x] Rename bubble-custom to bubble-module
- [x] Get modules config from this.config
- [x] Review ha-alert (alert when not copied in the right folder)
- [x] Fixed an issue with modules in combination with the text scrolling effect
- [x] Attempt to fix « Tap action on icon issue #990 »
- [x] No need to clear cache anymore to apply module modifications
- [x] Custom templates can be now placed anywhere and not only after custom styles
- [x] Fixed some styling issues in the Home Assistant default styling module
- [x] Fixed the pop-up compatibility with the new custom styles system 
- [x] Fixed some incompatibility issues in the cleanCSS function
- [x] Better « How to use » in bubble-modules.yaml
- [x] The new custom styles/template system handle name/state changes correctly 
- [x] And maybe more…
@Clooos
Copy link
Owner

Clooos commented Feb 15, 2025

Hi! It should be lot better now! 😃 Thanks again for the feedback!

https://github.com/Clooos/Bubble-Card/releases/tag/v2.5.0-beta.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants