Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling: setup error handling across the app #51

Open
Alex-Cannon opened this issue Oct 28, 2019 · 0 comments
Open

Error Handling: setup error handling across the app #51

Alex-Cannon opened this issue Oct 28, 2019 · 0 comments
Labels

Comments

@Alex-Cannon
Copy link
Collaborator

Alex-Cannon commented Oct 28, 2019

Needs #52 #53 to start work on this.

Any call to getGoogleSheet should be handled globally. This way we can keep track of errors more easily and output them to the admin's error page.

This is how things should work after this PR:

  1. When the app loads, the entire google sheet is pulled. This is available globally.
  2. After we get the google sheet, we need to test every category / service to make sure it is valid (not missing a category, has correct references, etc.) Utils for this will be done in Error handling: Extract and test sheet validation logic #52
  3. If a category / service is invalid, it will be removed from the results and the error will be logged on the /errors page, where admins can see warnings and errors about the sheet. See Error Handling: Create base Error page #53
  4. A link should appear on the home page with text along the lines of: "There was an error processing your data. Site admins please see the /errors page" (There should already be a component for this)
@Alex-Cannon Alex-Cannon changed the title Implement "single source of truth" or global state in the app Error Handling: Implement "single source of truth" or global state in the app Oct 28, 2019
@Alex-Cannon Alex-Cannon changed the title Error Handling: Implement "single source of truth" or global state in the app Error Handling: handle getGoogleSheet state globally Oct 28, 2019
@Alex-Cannon Alex-Cannon added this to the Handle errors across the app milestone Oct 28, 2019
@Alex-Cannon Alex-Cannon changed the title Error Handling: handle getGoogleSheet state globally Error Handling: setup getGoogleSheet error globally Oct 28, 2019
@Alex-Cannon Alex-Cannon changed the title Error Handling: setup getGoogleSheet error globally Error Handling: setup error handling across the app for getGoogleSheet Oct 29, 2019
@Alex-Cannon Alex-Cannon changed the title Error Handling: setup error handling across the app for getGoogleSheet Error Handling: setup error handling across the app Oct 29, 2019
@Alex-Cannon Alex-Cannon removed this from the Handle errors across the app milestone Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant