Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phosphor subclass BoxPanel to support restoreLayout #4

Open
robobenklein opened this issue Mar 17, 2022 · 2 comments
Open

Phosphor subclass BoxPanel to support restoreLayout #4

robobenklein opened this issue Mar 17, 2022 · 2 comments
Milestone
Stable Release

Comments

@robobenklein
Copy link
Member

The Ribbon components want to derive BoxPanel instead of the DockPanel like TheiaDockPanel does, however the phosphor BoxPanel is not feature-complete to DockPanel.
@robobenklein
Copy link
Member Author

new sub-implementation of ImprovedBoxPanel and ImprovedBoxLayout should be able to support the dock version of restore/save.

note to self: will want for IBL to check children for exported layout states (and fail nicely if they don't have them - like items in a patch might have scroll-position only for text?)

@robobenklein robobenklein added this to the Stable Release milestone Sep 4, 2022
@robobenklein
Copy link
Member Author

The primary ribbon looks to need it's own ILayoutConfig since it needs additional data like overview and focus, but I think for now IBL/IBP will handle the strip save/restore, since I don't think strips need any extra data on top of the BoxLayout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
VSCode-Compatible CodeRibbon
Status: Todo / Confirmed / Accepted
Milestone
Stable Release
Development

No branches or pull requests
1 participant
@robobenklein