Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new site template: Fullwidth with Header and Footer #79

Closed
JohnPixle opened this issue Nov 21, 2023 · 3 comments · Fixed by #83
Closed

Add new site template: Fullwidth with Header and Footer #79

JohnPixle opened this issue Nov 21, 2023 · 3 comments · Fixed by #83
Assignees
@HardeepAsrani
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Milestone
1.1.0

Comments

@JohnPixle
Copy link
Contributor

Currently, apart from the default page template that has a fixed content width, we have a fullwidth template (blank) that displays only the content, without the header and footer. But we don't have a full-width template that users can use with header and footer parts. This is quite useful, and I suggest we add this efficiency.

@HardeepAsrani This is the content for this template, let me know if it looks good and if you have any questions. If it does, feel free to register this in the theme.

<!-- wp:group {"style":{"spacing":{"margin":{"top":"0","bottom":"0"},"padding":{"top":"0","bottom":"0","left":"0","right":"0"},"blockGap":"0"}},"layout":{"inherit":false}} -->
<div class="wp-block-group" style="margin-top:0;margin-bottom:0;padding-top:0;padding-right:0;padding-bottom:0;padding-left:0"><!-- wp:post-content {"layout":{"type":"constrained","contentSize":"100%"}} /--></div>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer","theme":"raft","tagName":"footer"} /-->
@JohnPixle JohnPixle added the enhancement Request to improve or optimize an existing feature or functionality in the project label Nov 21, 2023
@JohnPixle JohnPixle added this to the 1.1.0 milestone Nov 21, 2023
@HardeepAsrani
Copy link
Member

@JohnPixle Not sure if it's intended or not but in your code, I don't see the header. That's a mistake, right?

@HardeepAsrani HardeepAsrani self-assigned this Nov 25, 2023
@HardeepAsrani HardeepAsrani added the tiny (1h) - This label is used for issues that can be completed in under an hour. label Nov 25, 2023
@HardeepAsrani HardeepAsrani mentioned this issue Nov 25, 2023
Merged
@JohnPixle
Copy link
Contributor Author

@HardeepAsrani I don't know how I managed to lose that part, but yes, it was a mistake 🙈

@JohnPixle JohnPixle linked a pull request Dec 7, 2023 that will close this issue
feat: page template with only header & footer #83
Merged
@HardeepAsrani HardeepAsrani mentioned this issue Dec 12, 2023
Merged
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HardeepAsrani HardeepAsrani

Labels
enhancement Request to improve or optimize an existing feature or functionality in the project released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

feat: page template with only header & footer Codeinwp/raft
3 participants
@HardeepAsrani @JohnPixle @pirate-bot