Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pan animation not panning across whole screen in landscape #34

Open
twhitbeck opened this issue Nov 14, 2014 · 2 comments
Open

Pan animation not panning across whole screen in landscape #34

twhitbeck opened this issue Nov 14, 2014 · 2 comments
Assignees

Comments

@twhitbeck
Copy link

In landscape the pan animation still only moves the portrait width of the screen. I'm using it to pan between viewcontrollers in a UITabBarController.

@ColinEberhardt
Copy link
Owner

Ah, good point, my test app doesn't use landscape. I'll look into this, although if you find a fix, I'm happy to receive a submission.

@ColinEberhardt ColinEberhardt self-assigned this Nov 15, 2014
@micnguyen
Copy link

Hi,

I'm using the PanAnimationController but noticed the magic number of 320. Is this referring to the width of iPhone 2/3/4/5? Running my app with the library, the presented viewcontroller starts and ends abruptly at the 320px point. That would also explain why the OP is having problems with landscape mode.

It really should be taking into account the width of the device's screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants