Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview 1.82.19 Hotfix Release #698

Draft
wants to merge 11 commits into
base: preview
Choose a base branch
from
Draft

Preview 1.82.19 Hotfix Release #698

wants to merge 11 commits into from

Conversation

bagusnl
Copy link
Member

@bagusnl bagusnl commented Feb 27, 2025

TBC Changelog

Blocking: #697 + re-check HSR's GSP formatting

ETA March W1

Templates

Changelog Prefixes
  **[New]**
  **[Imp]**
  **[Fix]**
  **[Loc]**
  **[Doc]**

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link

Qodana for .NET

12 new problems were found

Inspection name Severity Problems
Possible 'System.NullReferenceException' 🔶 Warning 4
Possible null reference argument for a parameter. 🔶 Warning 2
Unused local variable 🔶 Warning 2
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 1
'??' condition is known to be null or not null 🔶 Warning 1
Non-accessed positional property (non-private accessibility) 🔶 Warning 1
Redundant using directive 🔶 Warning 1

☁️ View the detailed Qodana report

Detected 73 dependencies

Third-party software list

This page lists the third-party software dependencies used in CollapseLauncher

Dependency Version Licenses
CommunityToolkit.Common 8.4.0 MIT
CommunityToolkit.Mvvm 8.4.0 MIT
CommunityToolkit.WinUI.Animations 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Behaviors 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Controls.Primitives 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Controls.Sizers 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Converters 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Extensions 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Helpers 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Media 8.2.250129-preview2 MIT
CommunityToolkit.WinUI.Triggers 8.2.250129-preview2 MIT
Costura.Fody 6.0.0 MIT
DependencyPropertyGenerator 1.5.0 MIT
DotNet.ReproducibleBuilds 1.2.25 MIT
EventGenerator.Generator 0.13.1 MIT
Fody 6.9.1 MIT
GitInfo 3.5.0 MIT
Google.Protobuf.Tools 3.29.3 PROTOBUF
Google.Protobuf 3.29.3 BSD-3-Clause
Hi3Helper.ZstdNet 1.6.3 BSD-3-Clause
Hi3Helper.ZstdNet 1.6.4 BSD-3-Clause
HtmlAgilityPack 1.11.72 MIT
Markdig.Signed 0.40.0 BSD-2-Clause
Microsoft.CSharp 4.7.0 MIT
Microsoft.DotNet.ILCompiler 9.0.1 MIT
Microsoft.Extensions.DependencyInjection.Abstractions 9.0.1 MIT
Microsoft.Extensions.DependencyInjection 9.0.1 MIT
Microsoft.Extensions.Logging.Abstractions 9.0.1 MIT
Microsoft.Extensions.Logging 9.0.1 MIT
Microsoft.Extensions.Options 9.0.1 MIT
Microsoft.Extensions.Primitives 9.0.1 MIT
Microsoft.Graphics.Win2D 1.3.2 MS-ASP-NET-WEB-OPTIMIZATION
Microsoft.NET.ILLink.Tasks 9.0.1 MIT
Microsoft.NET.ILLink.Tasks 9.0.2 MIT
Microsoft.NETCore.Targets 6.0.0-preview.4.21253.7 MIT
Microsoft.Web.WebView2 1.0.2957.106 BSD-3-Clause
BSD-MYLEX
Microsoft.Win32.SystemEvents 9.0.1 MIT
Microsoft.Windows.CsWin32 0.3.162 Apache-2.0
Microsoft.Windows.CsWinRT 2.2.0 MIT
Microsoft.Windows.SDK.BuildTools 10.0.22621.3233 PROPRIETARY-LICENSE
Microsoft.Windows.SDK.Win32Docs 0.1.42-alpha PROPRIETARY-LICENSE
Microsoft.Windows.SDK.Win32Metadata 61.0.15-preview MIT
Microsoft.Windows.WDK.Win32Metadata 0.12.8-experimental MIT
Microsoft.WindowsAppSDK 1.6.250108002 MIT
MS-DXSDK-D3DX-9.29.952.3
Microsoft.Xaml.Behaviors.WinUI.Managed 3.0.0 MIT
MinVer 6.0.0 Apache-2.0
NuGet.Versioning 6.12.1 Apache-2.0
PhotoSauce.MagicScaler 0.15.0 MIT
PhotoSauce.NativeCodecs.Libwebp 1.4.0-preview1 MIT
Roman-Numerals 2.0.1 MIT
Sentry 5.1.0 MIT
SharpCompress 0.39.0 MIT
SharpHDiffPatch.Core 2.2.8 MIT
System.Buffers 4.6.0 MIT
System.Drawing.Common 9.0.1 MIT
System.IO.Hashing 9.0.1 MIT
System.IO.Hashing 9.0.2 MIT
System.Net.Http 4.3.4 MIT
System.Security.AccessControl 6.0.1 MIT
System.Security.Cryptography.Algorithms 4.3.0 MIT
System.Security.Cryptography.Encoding 4.3.0 MIT
System.Security.Cryptography.Primitives 4.3.0 MIT
System.Security.Cryptography.ProtectedData 9.0.1 MIT
System.Security.Cryptography.X509Certificates 4.3.0 MIT
System.Text.Encoding.CodePages 9.0.1 MIT
System.Text.Json 9.0.1 MIT
System.Text.RegularExpressions 4.3.1 MIT
System.Threading.Tasks.Extensions 4.5.4 MIT
TaskScheduler 2.11.0 MIT
ThisAssembly.Constants 2.0.6 MIT
Velopack 0.0.1053 MIT
ZstdSharp.Port 0.8.4 MIT
runtime.win-x64.Microsoft.DotNet.ILCompiler 9.0.1 MIT
Contact Qodana team

Contact us at [email protected]

using Microsoft.UI.Xaml;
using System;

Check warning

Code scanning / QDNET

Redundant using directive Warning

Using directive is not required by the code and can be safely removed

// Get the mark file's relative path
string relativePathDir = Path.GetDirectoryName(localFileInfo.RelativePath) ?? "";
string relativePathNameNoExt = Path.GetFileNameWithoutExtension(localFileInfo.RelativePath) ?? "";

Check warning

Code scanning / QDNET

'??' condition is known to be null or not null Warning

'??' left operand is never null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants