Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend(ed) API Endpoint /publications/search/:search_params #58

Open
tbsvttr opened this issue Nov 9, 2022 · 10 comments
Open

Extend(ed) API Endpoint /publications/search/:search_params #58

tbsvttr opened this issue Nov 9, 2022 · 10 comments

Comments

@tbsvttr
Copy link
Collaborator

tbsvttr commented Nov 9, 2022

adding advanced search for reaction criteria
adding advanced search for sample criteria
adding advanced search for analysis criteria

http://193.196.38.77/swagger#/retrieve_id_list
https://docs.google.com/spreadsheets/d/1q6L_vbWorxLsvSVz7KCHMiNItZkyF4TwuhwzAwxh0pw/edit#gid=0

@tbsvttr tbsvttr changed the title Extend API Endpoint /publications/search/:search_params Extend(ed) API Endpoint /publications/search/:search_params Nov 9, 2022
@tbsvttr tbsvttr added this to the 8 milestone Nov 10, 2022
@tbsvttr tbsvttr assigned Respicite and unassigned JustLime Dec 2, 2022
@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Feb 8, 2023

@Respicite Which ones are still open?

@Respicite
Copy link
Contributor

Respicite commented Feb 8, 2023

Type Field Operator Status
Publication Published Date > = <  DONE
Publication Authors    DONE
Publication Contributor    DONE
Publication Embargo#    
Publication DOI    ?
Publication ORCID    
Publication Chemotion-ID    ?
Reaction Description LIKE  DONE
Reaction Short-RInChIKey LIKE  
Reaction Yield > = <  DONE
Reaction Temperature > = <  REMOVED
Sample Formula LIKE  
Sample InChIKey LIKE  
Sample SMILES LIKE  
Sample X-Vial LIKE  
Sample Description LIKE  DONE
Analysis Instrument    
Analysis Ontologies LIKE  
Analysis Description LIKE  DONE

@tbsvttr

@Respicite
Copy link
Contributor

@tbsvttr Though do we need a search by chemotion id / doi? We have an dedicated endpoint for them after all.

@Respicite
Copy link
Contributor

Also another question:
For yield and datum we have > = < but instead of having one field where you can define one such filter wouldn't it be better to have two fields for each to define the upper and lower bounds? (I mean we could also allow to dynamically add as many filters as wanted for each but that would make it much more complex / potentially taking a lot longer for the server to execute the query while being nearly no improvement for the user) @tbsvttr

@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Feb 9, 2023

@Respicite We do not do temperature, because of the problematic constraints we both found out to which Paggy agreed.

@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Feb 9, 2023

@Respicite I will ask about Chemotion ID and DOI. The only thing that would make sense for them is LIKE, because EQ is, as you say, implemented via another endpoint. Do not do anything here before I have an answer.

@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Feb 9, 2023

@Respicite Good work with the > = < search. I will ask about the upper and lower bound stuff. At the moment, leave it as it is and create a PR for it.

@Respicite
Copy link
Contributor

@tbsvttr #99

@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Mar 6, 2023

@Respicite Published Date and Yield done, aren't they?

@Respicite
Copy link
Contributor

@tbsvttr Yes they are since last month, we also had a talk about it around three weeks ago and IIRC everything was fine, or is something missing / should be changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants