Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Darkness Accuracy Malus has unexpected behavior #3415

Open
3 of 4 tasks
Neitherman opened this issue Sep 13, 2024 · 2 comments
Open
3 of 4 tasks

[Bug]: Darkness Accuracy Malus has unexpected behavior #3415

Neitherman opened this issue Sep 13, 2024 · 2 comments
Labels
Bug Something isn't working

Comments

@Neitherman
Copy link

Neitherman commented Sep 13, 2024

Rimworld version: 1.5.4104 rev435
Combat Extended version: 15.6.0.0
Combat Extended source (Steam, GitHub, etc.): Steam
Your operating system: Windows 10
Your mod list:
Harmony
Core
Royalty
Ideology
Biotech
Combat Extended

Description
For any difference in light condition between two pawns (Brightly Lit to Lit, Lit to darkness), the relative darkness penalty difference is always the same (8% between the two). On top of that, there is unexpected behavior when pawns are on the edge of lit and dark zones.

The recorded Darkness malus is as such:

Brightly Lit vs Lit - 21% vs 29%
Brightly Lit vs Dark - 42% vs 50%
Lit vs Dark  - 71%  vs 79%
Dark to Dark - 100% vs 100%

There are also cases where pawn straddling the line of lit to dark areas start showing incoherent darkness maluses. For example, a pawn in a brightly lit cell with dark cells on his side can fire at another pawn in a brightly lit cell surrounded by brightly cells with no malus. However the pawn firing back at him has suffers from the 29% malus.

Expected behavior
Consistent malus behavior when adjacent tiles aren't the same lighting level
Possibly more noticeable difference in term of malus? Someone hiding out in pitch darkness would probably have quite the advantage over someone lit under a flare. Whereas someone lit by the sun would have not that much of a disadvantage against one lit by a lamp

To reproduce
Put a pawn under a roof during peak light hours. Put a second pawn out in the sun. Check darkness malus in dev mode when trying to aim their gun at one another. Try with different light conditions, roofing, presence of walls next to the pawn, pawn relative positions too seem to cause different darkness maluses.

Screenshots & log dumps
Strange Behavior:
image
image
image

Complete the following checklist
I hereby verify that I have done the following:

  • Confirmed that my game version and load order are correct.
  • Confirmed that I am running the appropriate and most updated version of Combat Extended and required compatibility patches.
  • Confirmed I am not running any mods with known incompatibilities with Combat Extended.
  • Disabled Combat Extended and attempted to reproduce the behavior without success. (The behavior appears to be CE related)
@Neitherman Neitherman added the Bug Something isn't working label Sep 13, 2024
@Neitherman
Copy link
Author

Neitherman commented Sep 13, 2024

Another example of this incoherent behavior allowing for some... very weird abuse
image
image

@Neitherman Neitherman changed the title [Bug]: [Bug]: Darkness Accuracy Malus has unexpected behavior Sep 13, 2024
@SamaelGray
Copy link
Contributor

More test results showing the system's odd behavior: https://discord.com/channels/278818534069501953/303988654492090370/1284194752031494224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants