Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Deprecation of non-receiver functions in packet package #98

Open
WillGunther opened this issue Aug 6, 2018 · 0 comments
Open

Comments

@WillGunther
Copy link
Collaborator

Pull Request #92 moves to pointer receivers on the type Packet for interacting with the various fields of an mpeg TS packet. This creates duplicate functionality with functions that are already in place.

  • Proposal: To create parity with the other packages we would like to move towards pointer receivers for all the functions that interact with packet. This means deprecating many of the current functions in packet.go

We would love input and guidance from the open source community on whether these are worthwhile changes. If this is decided to be a valuable change the old functions would be depreciated, and removed in a few months time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant