[Bug]: The new Color Palette system cannot distinguish between original and previously modified Palettes

[JorgeR81]

Frontend Version

v1.7.1

Expected Behavior

All Palettes are shown ( like in v1.5.19 )

Actual Behavior

The Dark ( Default ) palette is not shown.

And custom palette, based on Dark ( Default ), is selected instead.

It seems that the new Color Palette system cannot distinguish between the original and the modified palettes.

Steps to Reproduce

This custom palette was created before the Color Palette system was changed.
I'm not sure if it would work correctly, with a new custom palette.

The Dark ( Default ) palette was exported, modified and imported back again, following these instructions:

• allow custom bypass color #993 (comment)

Debug Logs

.

Browser Logs

.

Setting JSON

.

What browsers do you use to access the UI ?

Google Chrome

Other

No response

┆Issue is synchronized with this Notion page by Unito

[webfiltered]

Toast shown on load when reproducing with cloned palette ("id": "notDark"):

[JorgeR81]

I tried to create a new custom palette, in the new Palette system, with the same instructions, but I've got this error:

---

So, I also changed the id ( from "dark" to "dark1" ), and now it works:

[JorgeR81]

I did some more testing:

• The new custom palette ( "Dark with Blue Bypass" - ID: "dark1" ), does not show in the old Palette menu.

• After deleting the old custom palette ( "Dark with Grey Bypass" - ID: "dark" ), in the old menu, the "Dark (Default)" Palette shows up in the new menu.

• Strangely, the new custom palette ( "Dark with Blue Bypass" - ID: "dark1" ) is also gone in the new menu.
  Maybe it was deleted automatically, when I used the old menu ?

---

• I re-imported back the new custom palette, ( "Dark with Blue Bypass" - ID: "dark1" ), in the new Palette menu, and it seems to work correctly.

[JorgeR81]

So it seems this issue can be "fixed" by the user.

But I will leave it open, in case you want to improve compatibility, between the old and new menus, for custom palettes.

[huchenlei]

Previously user defined palette had the id automatically prefixed with custom_, which were allowing id conflict with the system palettes.

The prefix was removed during the color palette rework. We can definitely add it back, but the original intention was to unify the id handling.