Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Feature] Add additional icons to check for quick actions #16

Open
Compile-Time opened this issue Jun 27, 2023 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@Compile-Time
Copy link
Owner

It seems that sometimes the icons shown by YouTube are not the same for all users.

This breaks the logic for detecting the correct option entry because there is no matching icon to be found.

Because we can not account for every individual situation where a users icon might be different to the default hard coded icons in the extension, some form of customization needs to be made available so users can add their unique icons as an additional check.

Some general ideas for this would be:

  • When an icon is not found show a popup that explains how the extension detects icons and provide a option to show the SVG path values for the current page.
    • The popup should be per page.
  • Explain the extensions behavior in the settings page where the additional icons can be added.
  • Re-work the settings page by removing the not-helpful log level setting and replacing it with the additional icons to check.
  • Add a Q&A section in the extension page explaining the above issue.
@Compile-Time
Copy link
Owner Author

Compile-Time commented Jun 29, 2023

Note: Some logic will be necessary to detect which parent element needs to be clicked. Currently, we don't click the SVG element itself to trigger any of the YouTube actions. It should be checked if clicking the SVG properly propagates the click because historically there was one case on the home page where clicking the button element of the more options button caused the video grid click event to be triggered. Therefore, it might be possible to run into unexpected behavior when not triggering the click on the right element.

@Compile-Time Compile-Time self-assigned this Dec 4, 2023
@Compile-Time Compile-Time added the enhancement New feature or request label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant