New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jest package adjustments after upgrade #5433

Open

nabramow opened this issue Jan 4, 2025 · 0 comments

Labels

1.topic frontend dependencies

Collaborator

nabramow commented Jan 4, 2025

Collecting @darrenvong 's comments in a separate ticket since the main PR already merged. Don't want to forget to address them.

"Out of interest, are there any reason you're using a Proxy over an object with an getter on it?" app/web/mocks/nextFontMock.js
tsconfig.json, compilerOptions => target, upgrade to "es2020" (from "es6")

nabramow added this to Couchers Engineering 💻

nabramow converted this from a draft issue

nabramow added dependencies 1.topic frontend labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment