Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade prettier and eslint-config-prettier #5485

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nabramow
Copy link
Collaborator

@nabramow nabramow commented Jan 18, 2025

Closes #5484

We haven't upgraded these packages for years so getting them up to date! The number of files makes this look much scarier than it is. There are so many changes as default format settings for prettier changed with the upgrade, so a lot of code formatting ran. Almost all the changes are trailing commas being added. So...not very risky ;-).

There shouldn't be any changes to any functionality here. So the only thing to look for will be if you have strong feelings about any of the new formatting.

See here for breaking changes: https://prettier.io/blog/2023/07/05/3.0.0.html#javascript

Web frontend checklist

  • [ x ] Formatted my code with yarn format
  • [ x ] There are no warnings from yarn lint --fix
  • [ x ] There are no console warnings when running the app
  • [ x ] All tests pass

Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
couchers ✅ Ready (Inspect) Visit Preview Jan 18, 2025 5:11am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade prettier and eslint-config-prettier
1 participant