Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Node Version? (10?) #23

Open
AlbinoDrought opened this issue Oct 8, 2018 · 3 comments
Open

Minimum Node Version? (10?) #23

AlbinoDrought opened this issue Oct 8, 2018 · 3 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@AlbinoDrought
Copy link
Member

While playing locally with the event emitter, I noticed the method off didn't exist for me - I found out it was added in node 10 (and of course I'm running an outdated version, as always).

Would it make sense to require Node >= 10 in package.json? Not sure what conflicts this could cause, what version Travis CI is running, etc

@AlbinoDrought AlbinoDrought added help wanted Extra attention is needed question Further information is requested labels Oct 8, 2018
@cocoastorm
Copy link
Member

For Travis CI we can probably configure the right or even multiple node.js versions. Also, I think supporting the LTS version (which I think is v8 right now?) is probably better.

Does the off method have a shim or polyfill we can optionally add in?

Then again limiting to just Node >= 10 doesn't seem awful.

@AlbinoDrought
Copy link
Member Author

I think removeEventListener does the same thing as off, but just looks more unwieldly.

(honestly not sure of differences between LTS and 10 - still have async/await support and all that jazz?)

@cocoastorm
Copy link
Member

I was looking at your recent PR, looks like we use a couple of modern features of ECMAScript :)

  • const and let
  • async and await (like you said)
  • object spread syntax
  • object.entries

I'd like to think Node.js v8 has most of this. We'll see, restricting it to Node.js 10 for now shouldn't be that big of a deal...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants