Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When is 1.0? #183

Closed
NullVoxPopuli opened this issue Aug 16, 2023 · 9 comments
Closed

When is 1.0? #183

NullVoxPopuli opened this issue Aug 16, 2023 · 9 comments

Comments

@NullVoxPopuli
Copy link
Contributor

atm, the latest version is just a beta: https://www.npmjs.com/package/ember-headless-form?activeTab=versions

@ynotdraw
Copy link
Contributor

I think we could probably cut a 1.0 now if we wanted to? What do you think @simonihmig ?

@simonihmig
Copy link
Contributor

Yeah, I was hoping to do so, but wondered if we need to consider support for server-originating validation errors (#143) before calling our APIs stable? But we can also consider it "just" a missing feature. I don't really anticipate that we would need to break any existing API when adding it later. What do you think?

@ynotdraw
Copy link
Contributor

I don't really anticipate that we would need to break any existing API when adding it later.

Yeah, this makes me feel as though fixing #143 could be a minor bump when ready, especially if no breaking API changes for that! 🎉

@bartocc
Copy link

bartocc commented Nov 23, 2023

Hey, just chiming in to know that status of this issue 😊

@ynotdraw
Copy link
Contributor

I think it's probably ready for a non-beta 1.0! I know we haven't hit any issues with it after about 5-6 months of use. What do you think @simonihmig?

@simonihmig
Copy link
Contributor

Yeah, we definitely need to do that! I was just embarrassed by myself the other day when I realized I haven't done this yet...

However, I came across some issue on Discord where passing an ember-data object to @data did not work. I want to look into this, as I think it should work. But hope we can finalize this next week (this week was a bit crazy)!

@bartocc
Copy link

bartocc commented Nov 23, 2023

I am experimenting with @data as a changeset wrapping a POJO at the moment, and will then wrap an ember-data object in the changeset.

I'll let you know if I hit any issue

@simonihmig
Copy link
Contributor

When is 1.0

Now, finally! 😅

@NullVoxPopuli
Copy link
Contributor Author

yay!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants