Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly exit powershell scripts #131

Open
ffalor opened this issue Jan 17, 2023 · 2 comments · Fixed by #128
Open

Properly exit powershell scripts #131

ffalor opened this issue Jan 17, 2023 · 2 comments · Fixed by #128
Labels
enhancement New feature or request migrate-script next release Issues targeted for next release no-issue-activity powershell
Milestone
1.8.0

Comments

@ffalor
Copy link
Contributor

ffalor commented Jan 17, 2023

Our powershell scripts should exit with specific exit codes based on errors.

Currently every "exit" is done by throw which makes using things like Start-Process very hard.
@ffalor ffalor added enhancement New feature or request powershell labels Jan 17, 2023
@carlosmmatos
Copy link
Contributor

carlosmmatos commented Jan 27, 2023 •
edited
Loading

Some work done in #128

@carlosmmatos carlosmmatos linked a pull request Mar 24, 2023 that will close this issue
add migrate script #128
Merged
@ffalor ffalor reopened this Mar 24, 2023
@ffalor ffalor added the next release Issues targeted for next release label May 22, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has had no activity in the last 14 days.

What happens next:
• The issue will be closed in 7 days if no further activity occurs
• To keep this issue open, simply leave a comment
• Once closed, please feel free to re-open if the issue persists

Thank you for your contributions to this project!

@carlosmmatos carlosmmatos added this to the 1.8.0 milestone Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request migrate-script next release Issues targeted for next release no-issue-activity powershell
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

add migrate script
2 participants
@ffalor @carlosmmatos