Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out the context cache from the consensus crate #313

Open
Boog900 opened this issue Oct 14, 2024 · 3 comments
Open

Split out the context cache from the consensus crate #313

Boog900 opened this issue Oct 14, 2024 · 3 comments
Assignees
Labels
C-proposal A proposal of some kind, and a request for comments. E-hard Hard difficulty. Experience needed to fix: A lot.

Comments

@Boog900
Copy link
Member

Boog900 commented Oct 14, 2024

What

The context cache is the service in cuprate-consensus that caches data from the database, this issue is for splitting it into a separate crate.

Why

We should pass in the data needed to verify a tx/block we shouldn't hold the context service in the verifiers. Splitting it into a separate crate makes this clearer.

@Boog900 Boog900 added C-proposal A proposal of some kind, and a request for comments. E-hard Hard difficulty. Experience needed to fix: A lot. labels Oct 14, 2024
@hinto-janai
Copy link
Contributor

@Boog900 @SyntheticBird45 is this closed by #318?

@SyntheticBird45
Copy link
Member

@hinto-janai As far as I understand it, there is a still second part to be achieved regarding the Why section

@Boog900
Copy link
Member Author

Boog900 commented Oct 23, 2024

The crate should be completed separated, cuprate-consensus shouldn't depend on the context crate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-proposal A proposal of some kind, and a request for comments. E-hard Hard difficulty. Experience needed to fix: A lot.
Projects
None yet
Development

No branches or pull requests

3 participants