From 467d24865f83c638256df4578871c6810d300b0f Mon Sep 17 00:00:00 2001 From: ChainsDD Date: Tue, 17 Aug 2010 17:19:51 -0500 Subject: [PATCH] Close a security hole that was causing the permission to not be enforced on request broadcast intents. --- su/activity.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/su/activity.cpp b/su/activity.cpp index c40607a4..4b21abd5 100644 --- a/su/activity.cpp +++ b/su/activity.cpp @@ -99,8 +99,7 @@ int send_intent(struct su_initiator *from, struct su_request *to, const char *so data.writeInt32(-1); /* resultCode */ data.writeString16(NULL, 0); /* resultData */ - data.writeInt32(-1); /* somewhere between these two lines is resultExtras */ - data.writeInt32(-1); /* not sure which line it is, but they both need to be here*/ + data.writeInt32(-1); /* resultExtras */ data.writeString16(String16("com.noshufou.android.su.RESPOND")); /* perm */ data.writeInt32(0); /* serialized */