-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsupported project types are included in the processing if they are referenced from a supported project type. #896
Comments
What error messages are you getting? |
Should work till version 2.10 I will have a look soon, shouldn't be a big issue to fix |
@mtsfoni Thank you. My quick fix to test was this (in RecursivelyGetProjectReferencesAsync) while (files.Count > 0)
{
var currentFile = files.Dequeue();
if (!Utils.IsSupportedProjectType(currentFile))
{
continue;
} |
@jwfx The app attempts to process a C++ nuget package from the .vcxproj and throws an error trying to process it. |
A fix for CycloneDX#896. When processing recursively through projects, apply the supported project test and skip any projects that do no satisfy the test Applied at release 3.0.8
A fix for CycloneDX#896. When processing recursively through projects, apply the supported project test and skip any projects that do no satisfy the test Applied at release 3.0.8 Signed-off-by: Peter Cullen <[email protected]>
A fix for CycloneDX#896. When processing recursively through projects, apply the supported project test and skip any projects that do no satisfy the test Signed-off-by: Peter Cullen <[email protected]>
I have opened a pull request to fix this. It has been tested and works in my case. |
A fix for CycloneDX#896. When processing recursively through projects, apply the supported project test and skip any projects that do no satisfy the test Applied at release 3.0.8 Signed-off-by: Peter Cullen <[email protected]>
We have a .sln that contains a mixture of .csproj and .vcxproj. The initial prcocessing in GetSolutionProjectReferencesAsync correctly removed invalid projects calling Utils.IsSupportedProjectType.
However the code just below this then loops through the valid projects and calls _projectFileService.RecursivelyGetProjectReferencesAsync to return a list of project references. It does not filter these references using Utils.IsSupportedProjectType. In my case this causes the program to crash attempting to process a .vcxproj.
The text was updated successfully, but these errors were encountered: