Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on Library with Vulnerability #1224

Closed
esarver opened this issue Oct 10, 2024 · 5 comments
Closed

Dependency on Library with Vulnerability #1224

esarver opened this issue Oct 10, 2024 · 5 comments
Labels
dependencies invalid This doesn't seem right

Comments

@esarver
Copy link

esarver commented Oct 10, 2024

Describe the bug

Dependency on libxmljs2 version <= 0.35.0 which is known to have a vulnerability labeled "High" (8.1): CVE-2024-34394.

Even if this is expected to not be an exploitable issue, those who include this tool as a Dev Dependency are getting Dependabot alerts.

Screenshots or output-paste

% npm audit

# npm audit report
libxmljs2  *
Severity: high
libxmljs2 type confusion vulnerability when parsing specially crafted XML - https://github.com/advisories/GHSA-mjr4-7xg5-pfvh
libxmljs2 vulnerable to type confusion when parsing specially crafted XML - https://github.com/advisories/GHSA-78h3-pg4x-j8cv
fix available via `npm audit fix --force`
Will install @cyclonedx/[email protected], which is a breaking change
node_modules/libxmljs2
  @cyclonedx/cyclonedx-library  >=1.14.0-rc.0
  Depends on vulnerable versions of libxmljs2
  node_modules/@cyclonedx/cyclonedx-library
    @cyclonedx/cyclonedx-npm  >=1.11.0
    Depends on vulnerable versions of @cyclonedx/cyclonedx-library
    node_modules/@cyclonedx/cyclonedx-npm

3 high severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

npm audit fix --force does not fix the issue.

@esarver esarver added the bug Something isn't working label Oct 10, 2024
@mikkopori
Copy link

Would be great to get a new release with this fixed :)

@jkowalleck
Copy link
Member

Dependency on libxmljs2 version <= 0.35.0 which is known to have a vulnerability labeled "High" (8.1): CVE-2024-34394.
The vulnerability is process driven and not active by default.

see also: CycloneDX/cyclonedx-javascript-library#1061

It assured that this vulnerability is not coming to action, the vulnerable code is not executed, and we have a unit test checking this: https://github.com/CycloneDX/cyclonedx-javascript-library/blob/bdbe727e48a34f6276a4e4a3056b11943fe9e2f4/tests/functional/internals/OpPlug.node.xmlValidator.implementation.spec.js#L70-L95

The dependency is required for XML-related features in this tool.
It is managed here: CycloneDX/cyclonedx-javascript-library#1079

@jkowalleck
Copy link
Member

jkowalleck commented Oct 23, 2024

npm audit fix --force does not fix the issue.

Would be great to get a new release with this fixed :)

there simply is no fix. there is, to my knowledge, no replacement.
but most important: there is no issue, there is nothing to fix - as stated above.

some background: the dependency/library COULD potentially cause issues, IF it was used wrong.
it is asserted, that it is NOT used wrong.

@mikkopori
Copy link

Thank you for clarifying this.

Of course for many projects we still get a warning, and if we have hundreds of warnings then tracking which are really relevant becomes hard.

Since https://www.npmjs.com/package/libxmljs2 is no longer maintained it should be replaced, or forked and the dependencies updated to move forward.

@jkowalleck
Copy link
Member

Since https://www.npmjs.com/package/libxmljs2 is no longer maintained it should be replaced, or forked and the dependencies updated to move forward.

thats what CycloneDX/cyclonedx-javascript-library#1079 is for.

As usual, this is free open source software - maintained by unpaid volunteers in their spare time. If you know a business that relies on this software, you are welcome to help improve that critical software your business runs on. For example, you could research replacements and publish your findings in that mentioned ticket, and donate the code to "move forward". :D

Any substantial help is more than welcome.

@jkowalleck jkowalleck pinned this issue Oct 24, 2024
@jkowalleck jkowalleck added dependencies and removed bug Something isn't working labels Oct 24, 2024
@jkowalleck jkowalleck changed the title [BUG] Dependency on Library with Vulnerability Dependency on Library with Vulnerability Oct 24, 2024
@jkowalleck jkowalleck added the invalid This doesn't seem right label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants