Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirement for sources to have a holding institution if source is a reconstruction #1631

Closed
2 tasks
dchiller opened this issue Sep 18, 2024 · 3 comments
Closed
2 tasks

Remove requirement for sources to have a holding institution if source is a reconstruction #1631

dchiller opened this issue Sep 18, 2024 · 3 comments
Assignees
@dchiller
Labels
priority: high

Comments

@dchiller
Copy link
Contributor

dchiller commented Sep 18, 2024 •
edited
Loading

As is being discussed in #1630, the holding institution relationship on a source is ill-suited for source reconstructions. While source reconstructions may, at some point, require additional attention in terms of how they are modeled, at present they can be accommodated by removing the requirement for a source to have a holding institution.

  • Make "Reconstruction" an option in the full_source field. (Change to ChoiceField).
  • Remove the requirement that a source have a holding institution relationship
@dchiller dchiller self-assigned this Sep 18, 2024
@ahankinson
Copy link
Member

Add a Boolean field to the source model tracking whether or not the source is a reconstruction

Right now full_source is a Boolean field in the database, but a choice field in the form. This seems really weird.

Why not make an actual choice field with Full Source, Fragment, and Reconstruction as options?

@dchiller
Copy link
Contributor Author

Right now full_source is a Boolean field in the database, but a choice field in the form. This seems really weird.

Hmm... that is weird. Yeah, this would be a good chance to clean that up. Revised steps above.

dchiller added a commit to dchiller/CantusDB that referenced this issue Oct 2, 2024
@dchiller
fix(source): make holding_institution optional for sources
be5962f 
This commit removes the requirement for a source to have a holding_institution.

Tests and forms are updated to account for this.

The `migrate_records` command is updated so that sources with un-parseable sigla that are not otherwise accounted for (by virtue of being private collections or prints) do not have institution records made.

Note: For the purposes of data migration, the `shelfmark` field is allowed to be NULL and no constraint is added to sources to designate when no holding institution is necessary. After migration, these should be modified.

Refs: DDMAL#1631
@dchiller dchiller mentioned this issue Oct 2, 2024
Merged
dchiller added a commit to dchiller/CantusDB that referenced this issue Oct 2, 2024
@dchiller
fix(source): make holding_institution optional for sources
a833370 
This commit removes the requirement for a source to have a holding_institution.

Tests and forms are updated to account for this.

The `migrate_records` command is updated so that sources with un-parseable sigla that are not otherwise accounted for (by virtue of being private collections or prints) do not have institution records made.

Note: For the purposes of data migration, no constraint is added to sources to designate when no holding institution is necessary. After migration, these should be modified.

Refs: DDMAL#1631
dchiller added a commit to dchiller/CantusDB that referenced this issue Oct 4, 2024
@dchiller
fix(source): make holding_institution optional for sources
d97563c 
This commit removes the requirement for a source to have a holding_institution.

Tests and forms are updated to account for this.

The `migrate_records` command is updated so that sources with un-parseable sigla that are not otherwise accounted for (by virtue of being private collections or prints) do not have institution records made.

Note: For the purposes of data migration, no constraint is added to sources to designate when no holding institution is necessary. After migration, these should be modified.

Refs: DDMAL#1631
@dchiller
Copy link
Contributor Author

Decided with Debra, Anna, Lucas that no source should have to have a holding institution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchiller dchiller

Labels
priority: high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahankinson @dchiller