Warn people about saving texts outside of protocol

[annamorphism]

Slight problem created by the solution of #1417 is that chants with asterisks don't save. These are used to indicate incipits, so we want them to be valid. (Noticed while trying to change something unrelated on a previously-published chant with an asterisk!)

[annamorphism]

Square brackets turn out to have the same problem (these are used for incomplete texts in the standardized spelling field).

[annamorphism]

actually this bug is preventing a lot of editing and proofreading on extant entries. giving it a high priority label.

[dchiller]

Temporarily turning off text validation in #1677 until this can be better addressed.

The asterisk thing makes sense -- it was an oversight because the syllabification validation follows the full text protocols, where asterisks aren't allowed [edited: they were always allowed 🤦]. But since now incipits are just drawn from the full text fields, they should be allowed! So definitely we need to change the validation for that!

As I wrote in an email re: square brackets:

For square brackets, these will be allowed if they are entered according to the text entry protocols. So my guess is someone is trying to enter them "incorrectly" — probably because some convention is being/has been developed that has not made it to the protocols? If you have an example we can pinpoint.

[annamorphism]

I was making a change to the image link on an already published chant (https://cantusdatabase.org/chant/693728) and not touching the text field.

I didn't have the forethought to get a screen shot the error message, but I do remember it was a closing bracket, so it's one or the other of these:

[dchiller]

So I guess first: is this a valid text entry? imho no.

Second, I was chatting with @lucasmarchd01 just now and the situation in which you encountered this -- there's already a bad text, you go in to change another field, should you be forced to fix the text before we allow you to save? -- came up. Instead, Lucas suggested that maybe we just show a warning, but still let you save what you came to the chant to edit.

[annamorphism]

This text seems valid to me? If not there are a lot of other texts like it...

I like @lucasmarchd01 idea to flag previously existing stuff. The reason we made this was originally to prevent stuff that would break on saving, not to flag other possibly-problematic things.

[dchiller]

This text seems valid to me? If not there are a lot of other texts like it...

That may be...as I say it could be that this is an unrecorded convention. So what's in the square brackets is text that is illegible in the source or missing from the source but that is interpolated based on a standard chant text? Basically equivalent to the curly braces in the source spelling field?

I'll modify the syllabifier to accord with whatever it is.

The reason we made this

Oops. Not totally sure what the "this" is here? Made what? The aforementioned use of square brackets?

[dchiller]

as I say it could be that this is an unrecorded convention.

So, it looks like (and this is ringing a bell now but I can't find documentation of where this was previously discussed) square brackets are allowed in that field according to the fragment entry protocols but not the text entry protocols.

[dchiller]

So what's in the square brackets is text that is illegible in the source or missing from the source but that is interpolated based on a standard chant text? Basically equivalent to the curly braces in the source spelling field?

Email from Debra confirms this, so I made DDMAL/volpiano-display-utilities#54 to implement the fix!

[dchiller]

Opened #1681 for a more permanent fix to the validation error point.

[annamorphism]

Oops. Not totally sure what the "this" is here? Made what? The aforementioned use of square brackets?

I meant, the problem originally being solved was to prevent people from creating unfixable chants by mistake. Square brackets and asterisks etc might be incorrectly used, but they don't create weird pathological objects when they are--so it's maybe not necessary to prevent people from using them incorrectly.

[dchiller]

I meant, the problem originally being solved was to prevent people from creating unfixable chants by mistake.

I see, thanks for the clarification. I think this is one problem and definitely the most urgent one.

I created #1312 a while back though too, and I think generally we shouldn't let people create bad chant texts. My assumption (perhaps incorrect) is that when people enter bad texts they aren't doing it maliciously or because the protocols can't handle the specific case, but because of unintentional mistakes (legitimately forgetting to close a bracket, for example) and so the validation can serve as a kind of "spell check". Perhaps not letting someone save a text is a bridge too far (what if they are just putting in a placeholder and will come back to correct?); in that case, maybe a pop-up that says "we've detected X in your chant text, which may cause syllabification and alignment problems/doesn't conform to the expected format. Are you sure you want to save?"

[annamorphism]

Right, I think we're in agreement.