Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chants out of order in sidebar #1682

Open
annamorphism opened this issue Oct 22, 2024 · 2 comments · May be fixed by #1683
Open

chants out of order in sidebar #1682

annamorphism opened this issue Oct 22, 2024 · 2 comments · May be fixed by #1683
Assignees
@dchiller

Comments

@annamorphism
Copy link

I'm looking at this chant https://cantusdatabase.org/chant/698887 (source not yet proofread, so maybe there is something weird underlying it). The previous/following chants show up in the sidebar in kind of a weird order...actually now I'm looking at it it seems to be alphabetical by feast? Anyway we want them ordered by sequence...

image
@dchiller dchiller self-assigned this Oct 22, 2024
@dchiller
Copy link
Contributor

@annamorphism Is this more what you are expecting (ie. still broken out by feast but with the feasts in order based on chant sequence?)

image

@annamorphism
Copy link
Author

yes! much better.

dchiller added a commit to dchiller/CantusDB that referenced this issue Oct 23, 2024
@dchiller
fix(chant detail): show nearby chants/feasts in correct order
319391f 
Removes superfluous queryset + adds docstring to `get_chants_with_feasts` function.

Refs: DDMAL#1682
@dchiller dchiller linked a pull request Oct 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchiller dchiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(chant detail): show nearby chants/feasts in correct order dchiller/CantusDB
2 participants
@dchiller @annamorphism