Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set branch protect rule #8

Open
junbeomlee opened this issue Jan 16, 2019 · 6 comments
Open

set branch protect rule #8

junbeomlee opened this issue Jan 16, 2019 · 6 comments
Labels
good first issue Good for newcomers

Comments

@junbeomlee
Copy link
Member

No description provided.

@junbeomlee junbeomlee added the good first issue Good for newcomers label Jan 16, 2019
@queuestack
Copy link
Collaborator

queuestack commented Jan 16, 2019

How about using master, develop, feature, hotfix branch?
master : branch for release
develop : integration branch for features
feature : branch for each feature, ex. feature/new-feature
hotfix: branch for fixing bug, ex hotfix/some-bug

Btw, some articles like gitflow suggests 'release' branch is needed.
I think our project can be covered without release branch.

@kwongiho
Copy link
Collaborator

@queuestack
I think we need 'release branch' for deploy and scheduling.
We can easily schedule the deployment with Milestone If we use the 'release branch'.
If not, we will have to set the exact rules for when to deploy it
Do you have any idea about this ?

@zeroFruit
Copy link
Member

I think both ideas are good. so how about make both branches?

@queuestack
Copy link
Collaborator

@kwongiho @zeroFruit
I agree with KwonGiho's opinion.
'release branch' will helps us to schedule the deployment.
It will be a good idea to use five branches in our project.

@queuestack
Copy link
Collaborator

Our bnach rules are set like below.

master : branch for release
release : branch for release.
develop : integration branch for features
feature : branch for each feature, ex. feature/new-feature
hotfix: branch for fixing bug, ex hotfix/some-bug

This issue should be closed after adding branch guide line to CONTRIBUTING.md

@kwongiho
Copy link
Collaborator

kwongiho commented Feb 1, 2019

I finished setting up the protect rule for master and develop branch.
We have to get one more approve before merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants