From f5da68896f99af90150b5380b1eed3d73b82cb22 Mon Sep 17 00:00:00 2001 From: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com> Date: Mon, 6 Jan 2025 16:05:23 +0000 Subject: [PATCH 1/3] update content --- app/views/teacher_training_adviser/steps/_identity.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/teacher_training_adviser/steps/_identity.html.erb b/app/views/teacher_training_adviser/steps/_identity.html.erb index f8987bd55a..542f3a8b12 100644 --- a/app/views/teacher_training_adviser/steps/_identity.html.erb +++ b/app/views/teacher_training_adviser/steps/_identity.html.erb @@ -2,7 +2,7 @@ <% content_for(:right_image) { "images/content/tta-sign-up/right.jpg" } %> <% content_for(:mobile_image) { "images/content/tta-sign-up/mobile.jpg" } %> -
If you're thinking about teaching in England, an adviser can provide free, one-to-one support by phone, From 1712aad2656bc32232a6c225a2f7bbe20f2d0081 Mon Sep 17 00:00:00 2001 From: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com> Date: Mon, 6 Jan 2025 16:18:24 +0000 Subject: [PATCH 2/3] update spec tests --- .../teacher_training_adviser/sign_up_spec.rb | 36 +++++++++---------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/spec/features/teacher_training_adviser/sign_up_spec.rb b/spec/features/teacher_training_adviser/sign_up_spec.rb index e853e8d42b..accc4830c8 100644 --- a/spec/features/teacher_training_adviser/sign_up_spec.rb +++ b/spec/features/teacher_training_adviser/sign_up_spec.rb @@ -54,7 +54,7 @@ visit teacher_training_adviser_step_path(:identity, channel: 123_456, sub_channel: sub_channel_id) click_on "Next step" - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" # Simulate en error to ensure channel id is not lost click_on "Next step" expect(page).to have_text("You need to enter your first name") @@ -133,7 +133,7 @@ visit "/teacher-training-advisers?channel=123456&sub_channel=#{sub_channel_id}" click_on "Next step" - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" # Simulate en error to ensure channel id is not lost click_on "Next step" expect(page).to have_text("You need to enter your first name") @@ -209,7 +209,7 @@ visit teacher_training_adviser_step_path(:identity, channel: 123_456) click_on "Next step" - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -275,7 +275,7 @@ scenario "that is a returning teacher" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -349,7 +349,7 @@ scenario "with an equivalent degree (overseas)" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -418,7 +418,7 @@ scenario "with an equivalent degree (UK)" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -485,7 +485,7 @@ scenario "with an equivalent degree" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -547,7 +547,7 @@ scenario "with an equivalent degree (UK)" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -610,7 +610,7 @@ scenario "studying for a degree (not final year)" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -674,7 +674,7 @@ scenario "studying for a degree (final year)" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -754,7 +754,7 @@ scenario "candidate changes an answer" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -831,7 +831,7 @@ scenario "candidate is a returning primary teacher" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -895,7 +895,7 @@ scenario "without a degree" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -914,7 +914,7 @@ scenario "without science GCSEs, primary" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -961,7 +961,7 @@ scenario "without english/maths GCSEs, primary" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -1000,7 +1000,7 @@ scenario "without GCSEs, secondary" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -1066,7 +1066,7 @@ scenario "matchback" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" @@ -1149,7 +1149,7 @@ scenario "skipping pre-filled optional steps" do visit teacher_training_adviser_steps_path - expect(page).to have_css "h1", text: "Get an adviser" + expect(page).to have_css "h1", text: "Get a free adviser" fill_in_identity_step click_on "Next step" From df473e6682f5a10e2d47c997ca728205fbd03086 Mon Sep 17 00:00:00 2001 From: emmaachesongray <168454683+emmaachesongray@users.noreply.github.com> Date: Tue, 7 Jan 2025 14:41:38 +0000 Subject: [PATCH 3/3] Change title header --- app/controllers/teacher_training_adviser/steps_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/teacher_training_adviser/steps_controller.rb b/app/controllers/teacher_training_adviser/steps_controller.rb index ff6ee4dbbd..f863a4bd6d 100644 --- a/app/controllers/teacher_training_adviser/steps_controller.rb +++ b/app/controllers/teacher_training_adviser/steps_controller.rb @@ -88,7 +88,7 @@ def crm_store end def set_step_page_title - @page_title = "Get an adviser" + @page_title = "Get a free adviser" if @current_step&.title @page_title += ", #{@current_step.title.downcase} step"