From 480b96dcec2cdeed84d84cd194ae7ee94289e097 Mon Sep 17 00:00:00 2001
From: Tomas D'Stefano <tomas_stefano@successoft.com>
Date: Thu, 17 Oct 2024 15:28:53 +0100
Subject: [PATCH] Replace content on school placements page

We will only show this page when provider chooses the school placements
to be selectable.
---
 app/controllers/find/placements_controller.rb |  2 +-
 app/views/shared/courses/_placements.html.erb |  7 +----
 config/locales/en.yml                         |  5 ++--
 .../find/placements_controller_spec.rb        | 28 +++++++++++++++++++
 .../find/search/viewing_a_course_spec.rb      |  3 ++
 5 files changed, 35 insertions(+), 10 deletions(-)

diff --git a/app/controllers/find/placements_controller.rb b/app/controllers/find/placements_controller.rb
index 6ef9176e74..b6d0bd4dae 100644
--- a/app/controllers/find/placements_controller.rb
+++ b/app/controllers/find/placements_controller.rb
@@ -2,7 +2,7 @@
 
 module Find
   class PlacementsController < ApplicationController
-    before_action -> { render_not_found if provider.nil? }
+    before_action -> { render_not_found if provider.nil? || provider.selectable_school.blank? }
 
     def index
       @course = provider.courses.includes(
diff --git a/app/views/shared/courses/_placements.html.erb b/app/views/shared/courses/_placements.html.erb
index 7e14fc8d87..9fe9280276 100644
--- a/app/views/shared/courses/_placements.html.erb
+++ b/app/views/shared/courses/_placements.html.erb
@@ -2,13 +2,8 @@
   <%= t(".heading", provider_name: course.provider_name) %>
 </h1>
 
-<%= govuk_warning_text(text: t(".warning")) %>
-
-<p class="govuk-body">
-  <%= t(".will_place_you", provider_name: course.provider_name) %>
-</p>
-
 <p class="govuk-body"><%= t(".schools_to_be_placed") %></p>
+<p class="govuk-body"><%= t(".schools_you_can_choose") %></p>
 
 <ul class="govuk-list govuk-list--spaced" id="course_school_placements">
   <% course.preview_site_statuses.each do |site_status| %>
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 4f06a987db..103d8a850c 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -31,9 +31,8 @@ en:
         heading: Contact %{provider_name}
       placements:
         heading: School placements at %{provider_name}
-        warning: You can’t pick which schools you will be in.
-        will_place_you: '%{provider_name} will place you in different schools you can travel to during your training.'
-        schools_to_be_placed: 'The schools you could be placed in are:'
+        schools_to_be_placed: You will be able to select a preferred placement location, but there is no guarantee you will be placed in the school you have chosen. The training provider will contact you to discuss your choice to help them select a location that suits you.
+        schools_you_can_choose: 'The schools you can choose from are:'
       school_placements_advice:
         view:
           heading: How school placements work
diff --git a/spec/controllers/find/placements_controller_spec.rb b/spec/controllers/find/placements_controller_spec.rb
index 9352925d65..2a59e87c93 100644
--- a/spec/controllers/find/placements_controller_spec.rb
+++ b/spec/controllers/find/placements_controller_spec.rb
@@ -20,6 +20,20 @@ module Find
         end
       end
 
+      context 'when provider sets school_placement as not selectable' do
+        it 'renders the not found page' do
+          provider = create(:provider, selectable_school: false)
+          course = create(:course, :published, provider:)
+
+          get :index, params: {
+            provider_code: provider.provider_code,
+            course_code: course.course_code
+          }
+
+          expect(response).to render_template('errors/not_found')
+        end
+      end
+
       context 'when course is not published' do
         it 'renders the not found page' do
           provider = create(:provider)
@@ -33,6 +47,20 @@ module Find
           expect(response).to render_template('errors/not_found')
         end
       end
+
+      context 'when course is published and school placement is selectable' do
+        it 'respond successfully' do
+          provider = create(:provider, selectable_school: true)
+          course = create(:course, :published, provider:)
+
+          get :index, params: {
+            provider_code: provider.provider_code,
+            course_code: course.course_code
+          }
+
+          expect(response).to have_http_status(:success)
+        end
+      end
     end
   end
 end
diff --git a/spec/features/find/search/viewing_a_course_spec.rb b/spec/features/find/search/viewing_a_course_spec.rb
index bd93565837..0cf16f1498 100644
--- a/spec/features/find/search/viewing_a_course_spec.rb
+++ b/spec/features/find/search/viewing_a_course_spec.rb
@@ -380,6 +380,9 @@ def when_i_click(button)
   alias_method :and_i_click, :when_i_click
 
   def then_i_should_be_on_the_school_placements_page
+    expect(page).to have_content(
+      'You will be able to select a preferred placement location, but there is no guarantee you will be placed in the school you have chosen. The training provider will contact you to discuss your choice to help them select a location that suits you.'
+    )
     @course.site_statuses.new_or_running.map(&:site).uniq.each do |site|
       expect(find_course_show_page).to have_content(smart_quotes(site.decorate.full_address))
     end