Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: standard deviation checks for should return indexes according to given likelihood #190

Open
SurfingNerd opened this issue Nov 17, 2023 · 3 comments
Open

tests: standard deviation checks for should return indexes according to given likelihood #190

SurfingNerd opened this issue Nov 17, 2023 · 3 comments
Labels
minor-issue Minor Issue that does not break anything.

Comments

@SurfingNerd
Copy link
Collaborator

the test for should return indexes according to given likelihood fails sometimes.
Either the RNG algorithm has a problem, or the math in the test that defines the standard deviation is wrong.
@SurfingNerd SurfingNerd moved this to Todo in Alpha4 Nov 17, 2023
@SurfingNerd
Copy link
Collaborator Author

occurence:
https://github.com/DMDcoin/diamond-contracts-core/actions/runs/10044921610/job/27761049567?pr=233

@SurfingNerd
Copy link
Collaborator Author

SurfingNerd commented Jul 23, 2024 •
edited
Loading

backup of code coverage output for prng deviation rng deviation.txt
As expected, rerunning the test succeeded, so it must be connected to on of those:

  • wrong estimation of PRNG deviation
  • wrong PRNG usage or implementation
  • Hardware (CPU) Bugs (unlikely)
  • ???

@SurfingNerd SurfingNerd added the minor-issue Minor Issue that does not break anything. label Oct 18, 2024
@SurfingNerd SurfingNerd removed this from Alpha4 Oct 18, 2024
@SurfingNerd
Copy link
Collaborator Author

occurence: https://github.com/SurfingNerd/diamond-contracts-core/actions/runs/11818947414/job/32927714601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor-issue Minor Issue that does not break anything.
Projects
Diamond Beta
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SurfingNerd