Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I-07] Define and use constant variables instead of using literals #64

Open
softstackio opened this issue Dec 10, 2024 · 0 comments · May be fixed by #68
Open

[I-07] Define and use constant variables instead of using literals #64

softstackio opened this issue Dec 10, 2024 · 0 comments · May be fixed by #68
Assignees

Comments

@softstackio
Copy link

Rather than using constant literal values, create a constant state variable and reference it throughout the contract.

6 Found Instances
  • Found in contracts/DiamondDao.sol Line: 169

            createProposalFeeAllowedParams[4] = 50 ether;
  • Found in contracts/DiamondDao.sol Line: 460

                requiredExceeding = totalStakedAmount * (50 * 100) / 10000;
  • Found in contracts/DiamondDao.sol Line: 462

                requiredExceeding = totalStakedAmount * (33 * 100) / 10000;
MSalman6 added a commit to MSalman6/diamond-contracts-dao that referenced this issue Jan 27, 2025
@MSalman6 MSalman6 linked a pull request Jan 27, 2025 that will close this issue
@Kris-DMD Kris-DMD moved this to In Progress in Diamond Beta Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants