Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error sending keygen transactions ReturnValueInvalid #30

Open
SurfingNerd opened this issue Aug 5, 2021 · 5 comments
Open

Error sending keygen transactions ReturnValueInvalid #30

SurfingNerd opened this issue Aug 5, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@SurfingNerd
Copy link
Collaborator

This happens if the network is booted up with the moc.
Does it happen only with the MOC ??

2021-08-05 02:45:13  Worker Hbbft0 TRACE engine  checking for acks...
2021-08-05 02:45:13  Worker Hbbft0 ERROR engine  could not retrieve part for 0x386f…f22d call failed. Error: ReturnValueInvalid
2021-08-05 02:45:13  Worker Hbbft0 ERROR engine  Error sending keygen transactions ReturnValueInvalid
@SurfingNerd
Copy link
Collaborator Author

no, experienced on testnet-alpha-4 as well.

2021-08-10 16:54:39  Verifier #0 TRACE engine  preparing to send PARTS for upcomming epoch: 2
2021-08-10 16:54:39  Verifier #0 TRACE engine  checking for acks...
2021-08-10 16:54:39  Verifier #0 ERROR engine  could not retrieve part for 0xd556��315f call failed. Error: ReturnValueInvalid
2021-08-10 16:54:39  Verifier #0 ERROR engine  Error sending keygen transactions ReturnValueInvalid
2021-08-10 16:54:39  Verifier #0 TRACE consensus  calling reward function for block 29 isEpochEnd? false on address: 0x2000��0001
2021-08-10 16:54:39  Verifier #0 TRACE txqueue  Refreshing certified addresses cache

The parts are written, but the node still complains:
could not retrieve part for 0xd556��315f call failed. Error: ReturnValueInvalid

@SurfingNerd
Copy link
Collaborator Author

happened with hbbft18 during testnet:
fun fact: he could not read his own part.

2021-08-26 12:00:58  Verifier #0 ERROR engine  could not retrieve part for 0x0ea7…fba6 call failed. Error: ReturnValueInvalid
2021-08-26 12:01:06  Verifier #3 ERROR engine  could not retrieve part for 0x0ea7…fba6 call failed. Error: ReturnValueInvalid
2021-08-26 12:01:13  Verifier #2 ERROR engine  could not retrieve part for 0x0ea7…fba6 call failed. Error: ReturnValueInvalid
2021-08-26 12:01:19  Verifier #0 ERROR engine  could not retrieve part for 0x0ea7…fba6 call failed. Error: ReturnValueInvalid
2021-08-26 12:01:26  Verifier #2 ERROR engine  could not retrieve part for 0x0ea7…fba6 call failed. Error: ReturnValueInvalid
2021-08-26 12:01:33  Verifier #1 ERROR engine  could not retrieve part for 0x0ea7…fba6 call failed. Error: ReturnValueInvalid
2021-08-26 12:06:22  Worker Hbbft3 TRACE engine  We are not part of the HoneyBadger validator set - running as regular node.

@SurfingNerd
Copy link
Collaborator Author

maybe connected with an epoch that hat multiple key generation rounds ?
so this could solve the problem:: #46

@SurfingNerd SurfingNerd added the bug Something isn't working label Nov 4, 2021
@SurfingNerd
Copy link
Collaborator Author

It happens on pending validators that just wait for other nodes to write their parts - or for waiting until it's own parts are getting included.

@SurfingNerd
Copy link
Collaborator Author

returning none instead of Err in part_of_address would reduce the error outpiut in the logfile - since it is not really an error.

    if serialized_part.is_empty() {
        return Err(CallError::ReturnValueInvalid);
    }

update to:

    if serialized_part.is_empty() {
        return Ok(None);
    }
´´´

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant