Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Write Lock reduction for HBBFT State #98

Open
SurfingNerd opened this issue Aug 23, 2022 · 2 comments
Open

Performance: Write Lock reduction for HBBFT State #98

SurfingNerd opened this issue Aug 23, 2022 · 2 comments
Labels
in test issue most likely fixed and currently in test.

Comments

@SurfingNerd
Copy link
Collaborator

HBBFT POSDAO checks currently hold a write lock, even if they are just reading the state.
We can split it up to only acquire a write lock after a read lock showed that we need to update the hbbft state.
SurfingNerd added a commit to SurfingNerd/openethereum-3.x that referenced this issue Aug 23, 2022
@SurfingNerd
POC implementation for reducing the required write locks for the hbbf…
360e6ee 
…t state during checking for epoch change.

but automated tests are failing on this. deeper analysis & fixing require.
DMDcoin#98
@SurfingNerd
Copy link
Collaborator Author

in development here: https://github.com/SurfingNerd/openethereum-3.x/tree/sn/i98-hbbft-state-locks
tests failing for unknown reasons - but worked in production.
Not going to merge without succeeeding tests.

@SurfingNerd SurfingNerd added the in test issue most likely fixed and currently in test. label Apr 25, 2024
@SurfingNerd
Copy link
Collaborator Author

we did a lock management optimization in diamond-node.
we still can take a review into this branch vs current implementation.
maybe there are good takes in this branch that are not implemented in diamond-node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in test issue most likely fixed and currently in test.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SurfingNerd