Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_timeseries_dsg() - add option to include 3rd netCDF dimension? #85

Open
hcorson-dosch-usgs opened this issue Mar 1, 2022 · 2 comments

Comments

@hcorson-dosch-usgs
Copy link

Currently write_timeseries_dsg() builds a netCDF with 2 dimensions: time and the instance names. Would it be within scope for that function to add the option to specify a 3rd dimension? Our use case would be packaging up timeseries of predicted lake temperature profiles, where we have the 3rd dimension of depth below the lake surface.

@dblodgett-usgs
Copy link
Collaborator

That would be in scope. One way to handle it would be to add the additional dimension and the data after creating the base file. Maybe you could mock that up and we could incorporate the code into a package function? The basic write_timeseries_dsg() function already has a ton going on.

@hcorson-dosch-usgs
Copy link
Author

Okay, thanks, Dave. That's a good thought to modify the file to add the extra dimension and data after building it with write_timeseries_dsg() and data for a single depth. We're in a bit of a sprint for our lake modeling project, so I will plan to write a function specific to our use case for now, trying out your suggested approach. I will link to the resulting function here, as I may have the bandwidth to return to this issue to make a more generic version later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants