Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tags for Outpost Structures #38

Open
BioMasterZap opened this issue Sep 3, 2024 · 0 comments
Open

Add Tags for Outpost Structures #38

BioMasterZap opened this issue Sep 3, 2024 · 0 comments

Comments

@BioMasterZap
Copy link

I have been testing this mod for my Mod Pack and noticed the "Ominous Banner to carry you to the nearest Outpost" doesn't work with modded outposts. I am using Revitalized Outposts which replaces "minecraft:pillager_outpost" with "revitalized_outposts:pillager_outpost" so when I give the Sniffer the banner, it just stops moving, unable to find a structure.

Would it be possible to add some sort of config or tag to allow users to change the Sniffer's structure target for modded structures? It could potentially even be a new structure tag so it could look for the nearest of multiple outposts (e.g. Towns and Towers adds a bunch of biome variants). Not sure how difficult it would be to change it to such a system, but if it were data-pack driven, it could also make it easier/nicer for users to add their own items for structures (e.g. a user could tag an item to sniff and list the structures it searches for). I could certainly think of some modded structures beyond just outposts I'd add if the option existed.

Another thing that is probably less likely, but would it be possible to add a tag for sniffer supported chests or specifically support mods like More Chests Variants? It seems it only works with the default Vanilla Chest, not even trapped, which makes sense given the model but even if they all used the normal chest model it would be nice if it could support other chests.

Also, it feels a bit weird the chest gives 4 rows on a Sniffer when it normally has 3 rows. Not sure if it could get a config option or if you'd want to change the default, but I'd personally go with 3 rows for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant