Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VocalTrack filled out to the best of my ability #479

Merged
merged 12 commits into from
Feb 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
224 changes: 112 additions & 112 deletions config/SZBE69/symbols.txt

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions config/SZBE69_B8/objects.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
"band3/bandtrack/Track.cpp": "NonMatching",
"band3/bandtrack/TrackConfig.cpp": "Matching",
"band3/bandtrack/TrackPanel.cpp": "NonMatching",
"band3/bandtrack/VocalTrack.cpp": "MISSING",
"band3/bandtrack/VocalTrack.cpp": "NonMatching",

"band3/game/AccuracyTracker.cpp": "NonMatching",
"band3/game/AccuracyTracker.cpp": "Matching",
"band3/game/Band.cpp": "NonMatching",
"band3/game/BandPerformer.cpp": "MISSING",
"band3/game/BandUser.cpp": "NonMatching",
Expand Down Expand Up @@ -88,7 +88,7 @@
"band3/game/StreakTracker.cpp": "NonMatching",
"band3/game/SyncGameStartPanel.cpp": "MISSING",
"band3/game/TambourineDetector.cpp": "MISSING",
"band3/game/TambourineManager.cpp": "MISSING",
"band3/game/TambourineManager.cpp": "NonMatching",
"band3/game/Tracker.cpp": "NonMatching",
"band3/game/TrackerDisplay.cpp": "NonMatching",
"band3/game/TrackerManager.cpp": "NonMatching",
Expand All @@ -102,7 +102,7 @@
"band3/game/VocalGuidePitch.cpp": "MISSING",
"band3/game/VocalOverlay.cpp": "MISSING",
"band3/game/VocalPart.cpp": "MISSING",
"band3/game/VocalPlayer.cpp": "MISSING",
"band3/game/VocalPlayer.cpp": "NonMatching",
"band3/game/VocalScoreHistory.cpp": "MISSING",
"band3/game/VocalTrainerPanel.cpp": "MISSING",

Expand Down
9 changes: 9 additions & 0 deletions src/band3/bandtrack/GraphicsUtl.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
#pragma once
#include "obj/Object.h"
#include "os/Debug.h"

void UnhookGroupParents(Hmx::Object *);
void UnhookAllParents(Hmx::Object *);

template <class T>
T *NewRndCopy(const T *obj) {
T *result = dynamic_cast<T *>(Hmx::Object::NewObject(T::StaticClassName()));
MILO_ASSERT(result, 0x22);
result->Copy(obj, Hmx::Object::kCopyShallow);
return result;
}
1 change: 1 addition & 0 deletions src/band3/bandtrack/Lyric.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class LyricPlate : public Hmx::Object {
float GetLastLyricXBeforeMS(float) const;
void Poll(float);
void BakeLyric(Lyric *);
bool Baked() const { return mBaked; }

float mWidthX; // 0x1c
int mNumCharsUsed; // 0x20
Expand Down
9 changes: 9 additions & 0 deletions src/band3/bandtrack/VocalStyle.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#pragma once

// i assume this would be scrolling vs static?
enum VocalStyle {
kVocalStyleStatic = 0,
kVocalStyleScrolling = 1,
kVocalStyleInvalid = 2,
kNumVocalStyles = 3
};
Loading