Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace std::regex to improve performance #1

Closed
DarkoGNU opened this issue Jan 5, 2022 · 1 comment
Closed

Replace std::regex to improve performance #1

DarkoGNU opened this issue Jan 5, 2022 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@DarkoGNU
Copy link
Owner

DarkoGNU commented Jan 5, 2022

SimpleLogo uses std::regex for some operations on std::string. This is fine, but std::regex is pretty slow.

This will be an issue if someone uses SimpleLogo to execute large scripts

Std::regex should be replaced either by a more efficient regex library (like Google's RE2) or by our own algorithms.

Won't fix for now - unless someone needs the performance improvement, this isn't worth fixing

@DarkoGNU DarkoGNU added enhancement New feature or request wontfix This will not be worked on labels Jan 5, 2022
@DarkoGNU
Copy link
Owner Author

Mentioned in #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant