Jeuno Quests: 'A Clock Most Delicate' - can't be started; 'Save the Clock Tower' - wrong starting NPC

[ibm2431]

I have:

• searched existing issues (http://github.com/darkstarproject/darkstar/issues/) to see if the issue I am posting has already been addressed or opened by another contributor
• checked the commit log to see if my issue has been resolved since my server was last updated

Client Version (type /ver in game) : n/a

Source Branch (master/stable) : master

Additional Information (Steps to reproduce/Expected behavior) :

(Preface: This is a case of an "implemented", but broken inaccurate quest in DSP. Not an unimplemented one.)

Derrick in Lower Jeuno is supposed to start SAVE_THE_CLOCK_TOWER (BG link). He does not.

In fact, he never has.

I suspect that some of those QUEST_ACCEPTED should be QUEST_AVAILABLE.
...He will also need to actually make a call to player:addQuest in the event finishes.

(Oh, and the fame check is missing, too.)

edit:
After doing some more digging, apparently we have the door responsible for a previous quest (A Clock Most Delicate) automatically starting Save the Clock Tower, without talking to Derrick.

While the door's event does mention the petition, both BG and FFXIclopedia say Derrick is what starts the quest.

edit 2:
So it turns out my original title was correct. The prerequisite quest, A Clock Most Delicate (FFXIclopedia), can't be started, so Save the Clock Tower can't be either. Let's run through this:

So at the moment, Galmut's Door in Upper Jeuno is what is (erroneously) starting Save the Clock Tower. (Side note: If you trigger this door on DSP, Galmut will appear and say "Oh, it's you...", as if he had previously met you despite the player not having done so. I can't say for certain that this is inaccurate behavior without checking retail.)

On DSP, starting Save the Clock Tower happens immediately upon completing A Clock Most Delicate, which is (correctly) started by said door.

But to gain access to the door, you must speak with Collet (and have requisite fame), who will set a char var to give you access, so you can trigger the door and start A Clock Most Delicate proper (which, again, is required for Save the Clock Tower).

However, Collet's script is checking if aClockMostdelicate is QUEST_AVAILABLE, without having actually assigned the variable to anything. And, well, she's always been broken.

So A Clock Most Delicate can't be started, and therefore, the entire quest line can't as well.

edit 3:
Apparently, when it was tested, that variable was being set globally via Galmut's Door.
(The global assignment got fixed.)

[TeoTwawki]

addvar/addcharvar: exists

Teo: (ಠ_ಠ)

its not like modifiers where we will always increment then decremented. no, we are going to be looking for a SPECIFIC value later, and its saner to set that EXACT value so that scriptwriters and debuggers know at a glance what value they are checking for in their getCharVar.

In before bossman tells you to make a delCharVar to decrement..