Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pre-commit in DTS repo #774

Closed
macpijan opened this issue Apr 3, 2024 · 2 comments · Fixed by Dasharo/dts-scripts#5
Closed

Implement pre-commit in DTS repo #774

macpijan opened this issue Apr 3, 2024 · 2 comments · Fixed by Dasharo/dts-scripts#5
Assignees

Comments

@macpijan
Copy link
Contributor

macpijan commented Apr 3, 2024

You can use pre-commit init script: https://github.com/3mdeb/hooks/tree/main/pre-commit-init that would help you to integrate create pre-commit configs. We will be mostly interested in shellcheck, as it will be mostly shell scripts here, but also markdown, codespell, conform, would be useful.

@DaniilKl
Copy link
Contributor

DaniilKl commented Apr 12, 2024

@macpijan, access error. Is 3mdeb/hooks configured appropriately?

dklimuk in ~/Repos/hooks on config-spell λ git push origin config-spell 
ERROR: Permission to 3mdeb/hooks.git denied to DaniilKl.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

P.S. Found a spell in the code in this repo.

@DaniilKl DaniilKl linked a pull request Apr 12, 2024 that will close this issue
@macpijan
Copy link
Contributor Author

Is 3mdeb/hooks configured appropriately?

should be now.

Thanks for contributing right away, I really appreciate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants