Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laptop wakes up from suspend on power change #783

Open
Ganneff opened this issue Apr 12, 2024 · 16 comments
Open

Laptop wakes up from suspend on power change #783

Ganneff opened this issue Apr 12, 2024 · 16 comments
Assignees
Labels
bug Something isn't working firmware novacustom_ns5x/7x_adl NovaCustom NS5x/7xPU (12th Gen) novacustom_ns5x/7x_tgl NovaCustom NS5x/7xMU (11th Gen)

Comments

@Ganneff
Copy link

Ganneff commented Apr 12, 2024

Component

Dasharo firmware

Device

NovaCustom NS5x 11th Gen

Dasharo version

1.5.2

Dasharo Tools Suite version

No response

Brief summary

Suspend laptop. Plug in/out power -> it runs again

How reproducible

100%

How to reproduce

Suspend the laptop. Plug in (or out) power. Laptop active again. (Current Debian bookworm. Laptop booted in firmware update mode tells me there is no update available, so current stable version in use).

Expected behavior

Stay in suspend.

Actual behavior

Laptop active.

Screenshots

No response

Additional context

No response

Solutions you've tried

Nothing in Bios/Uefi settings to adjust this.
Tried adjusting files/values in /sys/class/wakeup. Doesnt seem to work.

@Ganneff Ganneff added the bug Something isn't working label Apr 12, 2024
@github-actions github-actions bot added firmware novacustom_ns5x/7x_tgl NovaCustom NS5x/7xMU (11th Gen) novacustom_ns5x/7x_adl NovaCustom NS5x/7xPU (12th Gen) labels Apr 12, 2024
@PeterLacknase
Copy link

PeterLacknase commented Apr 17, 2024

Confirmed. Happens with clevo / novacustom nv41 (dasharo/ heads v0.9.0 - 2024-02-29) as well.

@mkopec
Copy link
Member

mkopec commented Apr 23, 2024

Have you tried the Power state after power failure option in the UEFI setup menu @Ganneff ? It should be responsible for this behavior

On the other hand, on Heads we do not have this option, and by default this feature should be disabled. Not sure what's causing it to be enabled yet, but it seems like a separate issue

@wessel-novacustom
Copy link

wessel-novacustom commented May 2, 2024

Have you tried the Power state after power failure option in the UEFI setup menu @Ganneff ? It should be responsible for this behavior

On the other hand, on Heads we do not have this option, and by default this feature should be disabled. Not sure what's causing it to be enabled yet, but it seems like a separate issue

@mkopec This is not a Heads related issue, but UEFI instead. The issue @PeterLacknase is referring to is probably this: #766

@mkopec I think you might not have understood the issue correctly. It is not powering on from S0 state when plugging in, but it is powering on from S0ix state when plugging in. I think this is as expected for modern standby, but is it possible to change this behaviour either by firmware or software so that the charger can be connected when the laptop is in S0ix, without the screen display turning on?

@mkopec
Copy link
Member

mkopec commented May 2, 2024

Ah, thanks for clarifying. I believe it should be possible to make it so that inserting a power supply does not wake the laptop.

@wessel-novacustom
Copy link

Ah, thanks for clarifying. I believe it should be possible to make it so that inserting a power supply does not wake the laptop.

@mkopec How? By firmware or on OS-side?

@Ganneff
Copy link
Author

Ganneff commented May 2, 2024

Have you tried the Power state after power failure option in the UEFI setup menu @Ganneff ? It should be responsible for this behavior

While Wessel already clarified its happening from Suspend to idle S0ix, still wanted to confirm, i set the option as . Unfortunately, no other option around to make it stop this.

@mkopec
Copy link
Member

mkopec commented Jun 3, 2024

@Ganneff @wessel-novacustom Could you clarify if this issue only happens on Debian? So far I haven't been able to reproduce on Ubuntu on NV4x and NS5x 11th gen

I do see this on Windows though, but Windows may be switching from disconnected to connected standby on AC plug in, so that would be expected

@PeterLacknase
Copy link

PeterLacknase commented Jun 3, 2024

It's completely OS independent. To reproduce:

[1] Shut down laptop (NV41 used over here) on battery power.
[2] Plug power cable from power adapter into a/the wall socket.
[3] Connect power adaptor with the laptop (preferably lid closed).

-> The laptop powers on.

@mkopec
Copy link
Member

mkopec commented Jun 11, 2024

@PeterLacknase As @wessel-novacustom mentioned above, your issue with Heads seems like #766 and it will be fixed in the next firmware relase

This issue is for waking from s0ix suspend (sleep mode) if I'm understanding this thread correctly

@wessel-novacustom @Ganneff Can you share more about the setup where this issue happens? I installed Debian 12 on NS5x 11th Gen and I cannot reproduce this issue. Are you testing with regular AC adapter or an USB-C adapter?

@PeterLacknase
Copy link

Right. That’s an issue, too. But it affected sleep state as well. In the mean time I found out, that it only happens with some USB-Sticks connected. With others (like nitrokey) everything works as expected.

@wessel-novacustom
Copy link

@wessel-novacustom @Ganneff Can you share more about the setup where this issue happens? I installed Debian 12 on NS5x 11th Gen and I cannot reproduce this issue. Are you testing with regular AC adapter or an USB-C adapter?

  • @Ganneff A video would be very helpful.

@Ganneff
Copy link
Author

Ganneff commented Jun 11, 2024

I have a normal Debian 12 setup. Disk encrypted, but standard Debian installer setup. UEFI Bios secure boot things not turned off.
KDE environment.

I do use USB-C for power.

Video: What do you want to see? Me using my phone showing how i unplug and it turns back on? A screenrecording of something?

@wessel-novacustom
Copy link

Video: What do you want to see? Me using my phone showing how i unplug and it turns back on?

  • Yes, exactly, so that the firmware developers can overview this behaviour and let you know if there is something we can do about it.

@macpijan macpijan added the heads label Jun 25, 2024
macpijan pushed a commit to Dasharo/heads that referenced this issue Jun 25, 2024
@macpijan macpijan removed the heads label Jun 26, 2024
@philipandag
Copy link

I could not reproduce the issue on NS51MU with Ubuntu 23.10 and Dasharo v1.5.2 release. No devices connected. Powered using a barrel jack.

@philipandag
Copy link

I will try to reproduce this configuration as closely as possible

I have a normal Debian 12 setup. Disk encrypted, but standard Debian installer setup. UEFI Bios secure boot things not turned off.
KDE environment.

I do use USB-C for power.

@philipandag
Copy link

I have installed Debian 12.6 Bookworm stable with encryption and KDE. Secure Boot on. Used both USB-C and barrel jack adapters. Dasharo v1.5.2 release. No USB devices.

I could not reproduce the issue of the laptop waking up from suspension when a power adapter is connected or disconnected during suspension.
Tried with both S3 and S0ix modes.

The laptop does power on if it is shut down and then the power adapter is connected. This behavior is controlled by Dasharo System Features -> Power Management Options -> Power state after power failure and setting it to "Powered off" causes the laptop to stay powered off after plugging in the power adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firmware novacustom_ns5x/7x_adl NovaCustom NS5x/7xPU (12th Gen) novacustom_ns5x/7x_tgl NovaCustom NS5x/7xMU (11th Gen)
Projects
Status: No status
Development

No branches or pull requests

7 participants