Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

battery bypass mode #843

Closed
baptx opened this issue May 30, 2024 · 10 comments
Closed

battery bypass mode #843

baptx opened this issue May 30, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@baptx
Copy link

baptx commented May 30, 2024

The problem you're addressing (if any)

On https://www.quora.com/How-often-should-I-charge-my-laptops-battery-to-prolong-its-lifespan/answer/Minhaz-Mahmud, I read "Most laptops now should be smart enough to bypass the battery once it hits 100% and just power the laptop directly."
I was told this is not the case currently, that there is no battery bypass mode on my NovaCustom NV41 Series laptop.

Describe the solution you'd like

All computers using Dasharo / coreboot should stop charging / using the battery when it is charged at 100% and the charger is plugged in.
This should be the case both for USB and DC charging. There also should be a reliable way to check that the battery is bypassed.

Where is the value to a user, and who might that user be?

Improve battery life of laptop users by not doing unnecessary charge / discharge.

Describe alternatives you've considered

Until there is a battery bypass mode when the battery is charged at 100%, it looks like there is a workaround by plugging out the charger and plugging it back in when the battery is charged above the minimum charge threshold (95% by default : https://docs.dasharo.com/unified/novacustom/features/#charge-thresholds).
I was able to keep the battery always at 96% when plugged in (with the message "fully charged" on Debian LXQt), so I guess it means the battery is successfully bypassed if the charge percentage does not change. Maybe this workaround is not needed but it is easier to verify the battery bypass when it is not 100% charged.

Additional context

No response

@baptx baptx added the enhancement New feature or request label May 30, 2024
@pietrushnic
Copy link

@baptx thank you for the report. @wessel-novacustom cc

@wessel-novacustom
Copy link

@baptx thank you for the report. @wessel-novacustom cc

It has been discussed already and it's planned for a next release, if I'm not wrong.

@macpijan cc

@mkopec
Copy link
Member

mkopec commented May 31, 2024

The NovaCustom laptops have charging circuits that already implement the requested feature. Only very space constrained devices like smartphones do not bypass the battery once it's fully charged. All NovaCustom laptops bypass the battery when it is not charging.

There is one exception, if you have a weak USB-C charger and try to stress the laptop so that it tries to draw more than the charger can provide, the battery will then come online to suply additional power (and turn off immediately when you don't need it anymore). This is a safety feature to prevent overdrawing power from chargers.

@wessel-novacustom
Copy link

@mkopec Can you confirm that this is the case for the current firmware versions already?

If so, can we check it with a Linux command that it is not actually charging?

@mkopec
Copy link
Member

mkopec commented May 31, 2024

cat /sys/class/power_supply/BAT0/current_now displays how much current (in microamps) is going through the battery (charging or discharging). When fully charged, the indicator should show 0.

@mkopec Can you confirm that this is the case for the current firmware versions already?

Yes, this is true for current firmware versions

@baptx
Copy link
Author

baptx commented Jun 1, 2024

@mkopec So the "battery bypass mode" that was planned for the next firmware release is cancelled since it is already built-in in the hardware?

@macpijan
Copy link
Contributor

@mkopec @wessel-novacustom Can we clarify here and close it? Do you think that we need some documentation update?

@wessel-novacustom
Copy link

@macpijan I suggest to explain the battery behaviour when fully charged here.

@philipandag
Copy link

philipandag commented Jul 25, 2024

Addressing the issue here: Dasharo/docs#864, Dasharo/edk2#155

@philipandag
Copy link

The documentation was updated to explain the battery behavior better.
Documentation

Additionally some information about setting optimal charge thresholds was be added to the help message in the setup menu and will probably be included in the next release.

You can check the Pull requests for details:
Dasharo/docs#864, Dasharo/edk2#155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

7 participants